Skip to content

Commit c7c3003

Browse files
bnbarhambnbarham
authored
Merge pull request #10618 from bnbarham/cherry-missing-lldb
[next] Cherry-pick Swift-specific LLDB adjustments
2 parents 8b07de4 + 4bf37fd commit c7c3003

18 files changed

+169
-121
lines changed

‎lldb/source/Core/Mangled.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,7 @@ ConstString Mangled::GetDemangledNameImpl(
351351
// explicitly unsupported on llvm.org.
352352
#ifdef LLDB_ENABLE_SWIFT
353353
{
354+
const char *mangled_name = m_mangled.GetCString();
354355
Log *log = GetLog(LLDBLog::Demangle);
355356
LLDB_LOGF(log, "demangle swift: %s", mangled_name);
356357
std::string demangled(SwiftLanguageRuntime::DemangleSymbolAsString(

‎lldb/source/Host/macosx/objcxx/HostInfoMacOSXSwift.cpp‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -285,12 +285,12 @@ HostInfoMacOSX::GetSwiftResourceDir(llvm::Triple triple,
285285
if (it != g_resource_dir_cache.end())
286286
return it->getValue();
287287

288-
auto value = DetectSwiftResourceDir(
289-
platform_sdk_path, swift_stdlib_os_dir,
290-
HostInfo::GetSwiftResourceDir().GetPath(),
291-
HostInfo::GetXcodeContentsDirectory().GetPath(),
292-
PlatformDarwin::GetCurrentToolchainDirectory().GetPath(),
293-
PlatformDarwin::GetCurrentCommandLineToolsDirectory().GetPath());
288+
auto value =
289+
DetectSwiftResourceDir(platform_sdk_path, swift_stdlib_os_dir,
290+
HostInfo::GetSwiftResourceDir().GetPath(),
291+
HostInfo::GetXcodeContentsDirectory().GetPath(),
292+
GetCurrentXcodeToolchainDirectory().GetPath(),
293+
GetCurrentCommandLineToolsDirectory().GetPath());
294294
g_resource_dir_cache.insert({key, value});
295295
return g_resource_dir_cache[key];
296296
}

‎lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848

4949
#include "llvm-c/Analysis.h"
5050
#include "llvm/ADT/ArrayRef.h"
51+
#include "llvm/ADT/RewriteBuffer.h"
5152
#include "llvm/ADT/StringRef.h"
5253
#include "llvm/BinaryFormat/Dwarf.h"
5354
#include "llvm/IR/IRBuilder.h"
@@ -62,7 +63,6 @@
6263
#include "llvm/TargetParser/Host.h"
6364

6465
#include "clang/Basic/Module.h"
65-
#include "clang/Rewrite/Core/RewriteBuffer.h"
6666

6767
#include "swift/AST/ASTContext.h"
6868
#include "swift/AST/DiagnosticConsumer.h"
@@ -1050,9 +1050,12 @@ MaterializeVariable(SwiftASTManipulatorBase::VariableInfo &variable,
10501050
// this check scattered in several places in the codebase, we should at
10511051
// some point centralize it.
10521052
lldb::StackFrameSP stack_frame_sp = stack_frame_wp.lock();
1053-
std::optional<uint64_t> size =
1053+
auto size_or_err =
10541054
variable.GetType().GetByteSize(stack_frame_sp.get());
1055-
if (repl && size && *size == 0) {
1055+
if (!size_or_err)
1056+
return size_or_err.takeError();
1057+
uint64_t size = *size_or_err;
1058+
if (repl && size == 0) {
10561059
auto &repl_mat = *llvm::cast<SwiftREPLMaterializer>(&materializer);
10571060
offset = repl_mat.AddREPLResultVariable(
10581061
variable.GetType(), variable.GetDecl(),
@@ -2341,7 +2344,7 @@ bool SwiftExpressionParser::RewriteExpression(
23412344
if (num_diags == 0)
23422345
return false;
23432346

2344-
clang::RewriteBuffer rewrite_buf;
2347+
llvm::RewriteBuffer rewrite_buf;
23452348
llvm::StringRef text_ref(m_expr.Text());
23462349
rewrite_buf.Initialize(text_ref);
23472350

‎lldb/source/Plugins/ExpressionParser/Swift/SwiftREPLMaterializer.cpp‎

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,13 @@ class EntityREPLResultVariable : public Materializer::Entity {
158158
ret->ValueUpdated();
159159

160160
if (variable) {
161-
const size_t pvar_byte_size = ret->GetByteSize().value_or(0);
161+
auto pvar_byte_size_or_err = ret->GetByteSize();
162+
if (!pvar_byte_size_or_err) {
163+
err = Status::FromError(pvar_byte_size_or_err.takeError());
164+
return;
165+
}
166+
167+
const uint64_t pvar_byte_size = *pvar_byte_size_or_err;
162168
uint8_t *pvar_data = ret->GetValueBytes();
163169

164170
Status read_error;
@@ -226,9 +232,13 @@ class EntityREPLResultVariable : public Materializer::Entity {
226232
demangle_ctx.clear();
227233
}
228234

229-
std::optional<uint64_t> size =
235+
auto size_or_err =
230236
m_type.GetByteSize(execution_unit->GetBestExecutionContextScope());
231-
if (size && *size == 0) {
237+
if (!size_or_err) {
238+
err = Status::FromError(size_or_err.takeError());
239+
return;
240+
}
241+
if (*size_or_err == 0) {
232242
MakeREPLResult(*execution_unit, err, nullptr);
233243
return;
234244
}
@@ -413,10 +423,15 @@ class EntityREPLPersistentVariable : public Materializer::Entity {
413423
FixupResilientGlobal(var_addr, compiler_type, *execution_unit,
414424
exe_scope->CalculateProcess(), read_error);
415425

426+
auto size_or_err = m_persistent_variable_sp->GetByteSize();
427+
if (!size_or_err) {
428+
err = Status::FromError(size_or_err.takeError());
429+
return;
430+
}
431+
416432
// FIXME: This may not work if the value is not bitwise-takable.
417-
execution_unit->ReadMemory(
418-
m_persistent_variable_sp->GetValueBytes(), var_addr,
419-
m_persistent_variable_sp->GetByteSize().value_or(0), read_error);
433+
execution_unit->ReadMemory(m_persistent_variable_sp->GetValueBytes(),
434+
var_addr, *size_or_err, read_error);
420435

421436
if (!read_error.Success()) {
422437
err = Status::FromErrorStringWithFormatv(
@@ -477,12 +492,13 @@ class EntityREPLPersistentVariable : public Materializer::Entity {
477492
if (!err.Success()) {
478493
dump_stream.Printf(" <could not be read>\n");
479494
} else {
480-
DataBufferHeap data(m_persistent_variable_sp->GetByteSize().value_or(0),
481-
0);
495+
uint64_t size =
496+
llvm::expectedToOptional(m_persistent_variable_sp->GetByteSize())
497+
.value_or(0);
498+
499+
DataBufferHeap data(size, 0);
482500

483-
map.ReadMemory(data.GetBytes(), target_address,
484-
m_persistent_variable_sp->GetByteSize().value_or(0),
485-
err);
501+
map.ReadMemory(data.GetBytes(), target_address, size, err);
486502

487503
if (!err.Success()) {
488504
dump_stream.Printf(" <could not be read>\n");

‎lldb/source/Plugins/Language/Swift/SwiftFormatters.cpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2050,8 +2050,8 @@ bool lldb_private::formatters::swift::SIMDVector_SummaryProvider(
20502050
return false;
20512051

20522052
ExecutionContext exe_ctx = valobj.GetExecutionContextRef().Lock(true);
2053-
std::optional<uint64_t> opt_type_size =
2054-
simd_type.GetByteSize(exe_ctx.GetBestExecutionContextScope());
2053+
std::optional<uint64_t> opt_type_size = llvm::expectedToOptional(
2054+
simd_type.GetByteSize(exe_ctx.GetBestExecutionContextScope()));
20552055
if (!opt_type_size)
20562056
return false;
20572057
uint64_t type_size = *opt_type_size;
@@ -2065,8 +2065,8 @@ bool lldb_private::formatters::swift::SIMDVector_SummaryProvider(
20652065
if (!arg_type)
20662066
return false;
20672067

2068-
std::optional<uint64_t> opt_arg_size =
2069-
arg_type.GetByteSize(exe_ctx.GetBestExecutionContextScope());
2068+
std::optional<uint64_t> opt_arg_size = llvm::expectedToOptional(
2069+
arg_type.GetByteSize(exe_ctx.GetBestExecutionContextScope()));
20702070
if (!opt_arg_size)
20712071
return false;
20722072
uint64_t arg_size = *opt_arg_size;

‎lldb/source/Plugins/Language/Swift/SwiftFrameRecognizers.cpp‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,12 +197,14 @@ class SwiftHiddenFrameRecognizer : public StackFrameRecognizer {
197197
if (!sc.function)
198198
return {};
199199

200-
FileSpec source_file;
200+
SupportFileSP source_file_sp;
201201
uint32_t line_no;
202-
sc.function->GetStartLineSourceInfo(source_file, line_no);
202+
sc.function->GetStartLineSourceInfo(source_file_sp, line_no);
203203
// FIXME: these <compiler-generated> frames should be marked artificial
204204
// by the Swift compiler.
205-
if (source_file.GetFilename() == "<compiler-generated>" && line_no == 0)
205+
if (source_file_sp &&
206+
source_file_sp->GetSpecOnly().GetFilename() == "<compiler-generated>" &&
207+
line_no == 0)
206208
return m_hidden_frame;
207209

208210
auto symbol_name =

‎lldb/source/Plugins/Language/Swift/SwiftLanguage.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -845,7 +845,7 @@ ExtractSwiftTypeNameFromCxxInteropType(CompilerType type) {
845845
}
846846

847847
const clang::RecordDecl *record_decl = record_type->getDecl();
848-
auto *metadata = tsc->GetMetadata(record_decl);
848+
auto metadata = tsc->GetMetadata(record_decl);
849849
if (metadata && !metadata->GetIsPotentiallySwiftInteropType())
850850
return {};
851851

‎lldb/source/Plugins/Language/Swift/SwiftOptionSet.cpp‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ void lldb_private::formatters::swift::SwiftOptionSetSummaryProvider::
118118
std::string lldb_private::formatters::swift::SwiftOptionSetSummaryProvider::
119119
GetDescription() {
120120
StreamString sstr;
121-
sstr.Printf("`%s `%s%s%s%s%s%s%s", "Swift OptionSet summary provider",
121+
sstr.Printf("`%s `%s%s%s%s%s%s%s", GetName().c_str(),
122122
Cascades() ? "" : " (not cascading)", " (may show children)",
123123
!DoesPrintValue(nullptr) ? " (hide value)" : "",
124124
IsOneLiner() ? " (one-line printout)" : "",
@@ -128,6 +128,11 @@ std::string lldb_private::formatters::swift::SwiftOptionSetSummaryProvider::
128128
return sstr.GetString().str();
129129
}
130130

131+
std::string
132+
lldb_private::formatters::swift::SwiftOptionSetSummaryProvider::GetName() {
133+
return "Swift OptionSet summary provider";
134+
}
135+
131136
bool lldb_private::formatters::swift::SwiftOptionSetSummaryProvider::
132137
FormatObject(ValueObject *valobj, std::string &dest,
133138
const TypeSummaryOptions &options) {

‎lldb/source/Plugins/Language/Swift/SwiftOptionSet.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ struct SwiftOptionSetSummaryProvider : public TypeSummaryImpl {
3434
bool FormatObject(ValueObject *valobj, std::string &dest,
3535
const TypeSummaryOptions &options) override;
3636
std::string GetDescription() override;
37+
std::string GetName() override;
3738
bool DoesPrintChildren(ValueObject *valobj) const override;
3839

3940
private:

‎lldb/source/Plugins/Language/Swift/SwiftOptional.cpp‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ using namespace lldb_private::formatters::swift;
2828
std::string lldb_private::formatters::swift::SwiftOptionalSummaryProvider::
2929
GetDescription() {
3030
StreamString sstr;
31-
sstr.Printf("`%s `%s%s%s%s%s%s%s", "Swift.Optional summary provider",
31+
sstr.Printf("`%s `%s%s%s%s%s%s%s", GetName().c_str(),
3232
Cascades() ? "" : " (not cascading)", " (may show children)",
3333
!DoesPrintValue(nullptr) ? " (hide value)" : "",
3434
IsOneLiner() ? " (one-line printout)" : "",
@@ -38,6 +38,11 @@ std::string lldb_private::formatters::swift::SwiftOptionalSummaryProvider::
3838
return sstr.GetString().str();
3939
}
4040

41+
std::string
42+
lldb_private::formatters::swift::SwiftOptionalSummaryProvider::GetName() {
43+
return "Swift.Optional summary provider";
44+
}
45+
4146
/// If this ValueObject is an Optional<T> with the Some(T) case selected,
4247
/// retrieve the value of the Some case.
4348
///

0 commit comments

Comments
 (0)