Skip to content

Commit cbd3283

Browse files
[AMDGPU] Simplify PrintField::printField (NFC) (llvm#137502)
We can use "constexpr if" to combine the two variants of functions.
1 parent e4feb2d commit cbd3283

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -222,22 +222,17 @@ static int get_amd_kernel_code_t_FieldIndex(StringRef name) {
222222

223223
class PrintField {
224224
public:
225-
template <typename T, T AMDGPUMCKernelCodeT::*ptr,
226-
typename std::enable_if_t<!std::is_integral_v<T>, T> * = nullptr>
225+
template <typename T, T AMDGPUMCKernelCodeT::*ptr>
227226
static void printField(StringRef Name, const AMDGPUMCKernelCodeT &C,
228227
raw_ostream &OS, MCContext &Ctx,
229228
AMDGPUMCKernelCodeT::PrintHelper Helper) {
230-
OS << Name << " = ";
231-
const MCExpr *Value = C.*ptr;
232-
Helper(Value, OS, Ctx.getAsmInfo());
233-
}
234-
235-
template <typename T, T AMDGPUMCKernelCodeT::*ptr,
236-
typename std::enable_if_t<std::is_integral_v<T>, T> * = nullptr>
237-
static void printField(StringRef Name, const AMDGPUMCKernelCodeT &C,
238-
raw_ostream &OS, MCContext &,
239-
AMDGPUMCKernelCodeT::PrintHelper) {
240-
OS << Name << " = " << (int)(C.*ptr);
229+
if constexpr (!std::is_integral_v<T>) {
230+
OS << Name << " = ";
231+
const MCExpr *Value = C.*ptr;
232+
Helper(Value, OS, Ctx.getAsmInfo());
233+
} else {
234+
OS << Name << " = " << (int)(C.*ptr);
235+
}
241236
}
242237
};
243238

0 commit comments

Comments
 (0)