Skip to content

Commit f8cb8e0

Browse files
authored
Merge pull request #11361 from jasonmolenda/cp/r158630250-debugserver-speedtest-packet-6.2.1
[lldb][debugserver] Max response size for qSpeedTest (llvm#156099)
2 parents ecea917 + 2b5d5cc commit f8cb8e0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lldb/tools/debugserver/source/RNBRemote.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4519,12 +4519,12 @@ rnb_err_t RNBRemote::HandlePacket_qSpeedTest(const char *p) {
45194519
return HandlePacket_ILLFORMED(
45204520
__FILE__, __LINE__, p,
45214521
"Didn't find response_size value at right offset");
4522-
else if (*end == ';') {
4523-
static char g_data[4 * 1024 * 1024 + 16];
4524-
strcpy(g_data, "data:");
4525-
memset(g_data + 5, 'a', response_size);
4526-
g_data[response_size + 5] = '\0';
4527-
return SendPacket(g_data);
4522+
else if (*end == ';' && response_size < (4 * 1024 * 1024)) {
4523+
std::vector<char> buf(response_size + 6, 'a');
4524+
memcpy(buf.data(), "data:", 5);
4525+
buf[buf.size() - 1] = '\0';
4526+
rnb_err_t return_value = SendPacket(buf.data());
4527+
return return_value;
45284528
} else {
45294529
return SendErrorPacket("E79");
45304530
}

0 commit comments

Comments
 (0)