[BoundsSafety][NFC] Unbreak codegen tests due to profile metadata on trap branches #10481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…codegen tests This is to help fix the tests failures in rdar://148767987
…trap branches ``` commit 30f2e92 Author: Florian Mayer <[email protected]> Date: Fri Apr 4 10:58:08 2025 -0700 [clang] [sanitizer] predict trap checks succeed (llvm#134310) Trap checks fail at most once (when the program crashes). ``` added profile metadata to trap branches that says its likely the trap succeeds. This shows up in the IR which broke many of our codegen tests. Many of the tests were automatically updated using `clang/utils/bounds_safety_fixup_codegen_tests.sh` but several had to be updated by hand. rdar://148767987
delcypher
added
the
clang:bounds-safety
Author
|
Landing now to unbreak the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm#134310 broke lots of codegen tests so this PR fixes them.
This PR also includes a handy script that can regenerate many of the codegen tests easily.