[Cherry-pick][swift/release/6.2] fix vardecl init serialization #11386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This serializes the result of VarDecl::hasInitWithSideEffects, to prevent triggering deserialization of the initializer expression when deserialization is already occurring.
Issues: rdar://154717930
Original PRs: llvm#143739 llvm#146468 llvm#147378
Risk: Low, this has been in llvm.org/main for a while now
Testing: Added a regression test.
Reviewers: @benlangmuir