[BoundsSafety][LLDB] Fix lldb/test/Shell/BoundsSafety/boundssafetytrap.test
#11656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap.test` When swiftlang#11621 (a4898c2) landed it broke this test because the trap reason string changed and this test wasn't updated. rdar://162886933
delcypher
added
the
clang:bounds-safety
Author
|
@adrian-prantl @Michael137 @rapidsna I'm just going to land this now because there is only one right way to fix this. |
Michael137
reviewed
Oct 19, 2025
Michael137
left a comment
Michael137
left a comment
There was a problem hiding this comment.
@delcypher Just out of curiosity, are there cases where the debugger would stop in a frame that's different to the expression printed in the stop reason?
Could that get confusing to the user? If so, does something in LLDB need to be adjusted to align the two?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #11621
(a4898c2) landed it broke this test
because the trap reason string changed and this test wasn't updated.
rdar://162886933