[cherry-pick][lldb] Add OS plugin property for reporting all threads (#123145) #9852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, an LLDB target option controls whether plugins report all threads. However, it seems natural for this knowledge could come from the plugin itself. To support this, this commits adds a virtual method to the plugin base class, making the Python OS query the target option to preserve existing behavior. (cherry picked from commit cb82771)
Author
|
Cherry pick from upstream llvm#123145 |
Author
|
@swift-ci test |
Author
|
@swift-ci test platform macos |
Author
|
@swift-ci test macOS platform |
adrian-prantl
approved these changes
Jan 17, 2025
| Global, | ||
| DefaultTrue, | ||
| Desc<"Set to False if your OS Plugins doesn't report all threads on each stop.">; | ||
| Desc<"Set to False if your Python OS Plugin doesn't report all threads on each stop.">; |
There was a problem hiding this comment.
Suggested change
| Desc<"Set to False if your Python OS Plugin doesn't report all threads on each stop.">; | |
| Desc<"Set to False if your scripted OS Plugin doesn't report all threads on each stop.">; |
felipepiovezan
deleted the
felipe/cherry-pick-plugin-reports-all-threads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an LLDB target option controls whether plugins report all threads. However, it seems natural for this knowledge could come from the plugin itself. To support this, this commits adds a virtual method to the plugin base class, making the Python OS query the target option to preserve existing behavior.
(cherry picked from commit cb82771)