Fix a memory leak

ahoppen · ahoppen · commit 2446a3260494 · 2024-09-18T07:55:15.000-07:00
We had a retain cycle from `BuildSystemManager` to `LocalConnection`. Fix it by making `LocalConnection` have a weak reference to `BuildSystemManager`.
diff --git a/Sources/BuildSystemIntegration/BuildSystemManager.swift b/Sources/BuildSystemIntegration/BuildSystemManager.swift
@@ -206,7 +206,7 @@ package actor BuildSystemManager: QueueBasedMessageHandler {
       toolchainRegistry: toolchainRegistry,
       options: options,
       buildSystemTestHooks: buildSystemTestHooks,
-      messagesToSourceKitLSPHandler: self
+      messagesToSourceKitLSPHandler: WeakMessageHandler(self)
     )
     if let buildSystem {
       let connectionToBuildSystem = LocalConnection(receiverName: "Build system")

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ package actor BuildSystemManager: QueueBasedMessageHandler {`
`206`	`206`	`toolchainRegistry: toolchainRegistry,`
`207`	`207`	`options: options,`
`208`	`208`	`buildSystemTestHooks: buildSystemTestHooks,`
`209`		`- messagesToSourceKitLSPHandler: self`
	`209`	`+ messagesToSourceKitLSPHandler: WeakMessageHandler(self)`
`210`	`210`	`)`
`211`	`211`	`if let buildSystem {`
`212`	`212`	`let connectionToBuildSystem = LocalConnection(receiverName: "Build system")`