address more review comments

Author: matthewbastien

Sources/SourceKitLSP/Swift/OnDiskDocumentManager.swift

@@ -27,7 +27,7 @@ actor OnDiskDocumentManager: Sendable {
   private weak var sourceKitLSPServer: SourceKitLSPServer?
   private var openSnapshots: [DocumentURI: (snapshot: DocumentSnapshot, patchedCompileCommand: SwiftCompileCommand?)]
 
-  init(sourceKitLSPServer: SourceKitLSPServer) {
+  fileprivate init(sourceKitLSPServer: SourceKitLSPServer) {
     self.sourceKitLSPServer = sourceKitLSPServer
     self.openSnapshots = [:]
   }
@@ -38,7 +38,7 @@ actor OnDiskDocumentManager: Sendable {
   ///
   /// - Parameter symbolLocation: The location of the symbol to fetch the symbol graph for.
   func fetchSymbolGraph(at symbolLocation: SymbolLocation) async throws -> String? {
-    let (snapshot, patchedCompileCommand) = try await openDocumentSnapshot(at: symbolLocation)
+    let (snapshot, patchedCompileCommand) = try await openDocumentSnapshot(for: symbolLocation.documentUri)
     let swiftLanguageService = try await swiftLanguageService(for: symbolLocation.documentUri)
     return try await swiftLanguageService.cursorInfo(
       snapshot,
@@ -48,19 +48,6 @@ actor OnDiskDocumentManager: Sendable {
     ).symbolGraph
   }
 
-  /// Open a unique dummy document in sourcekitd that has the contents of the file on disk for uri, but an arbitrary
-  /// URI which doesn't exist on disk.
-  ///
-  /// The document will be retained until ``closeAllDocuments()`` is called. This will avoid parsing the same
-  /// document multiple times if more than one symbol needs to be looked up.
-  ///
-  /// - Parameter symbolLocation: The location of the document that will be opened.
-  func openDocumentSnapshot(
-    at symbolLocation: SymbolLocation
-  ) async throws -> (snapshot: DocumentSnapshot, patchedCompileCommand: SwiftCompileCommand?) {
-    try await openDocumentSnapshot(for: symbolLocation.documentUri)
-  }
-
   /// Open a unique dummy document in sourcekitd that has the contents of the file on disk for uri, but an arbitrary
   /// URI which doesn't exist on disk.
   ///
@@ -71,16 +58,16 @@ actor OnDiskDocumentManager: Sendable {
   func openDocumentSnapshot(
     for uri: DocumentURI
   ) async throws -> (snapshot: DocumentSnapshot, patchedCompileCommand: SwiftCompileCommand?) {
-    guard let cachedSnapshot = openSnapshots[uri] else {
-      let languageService = try await swiftLanguageService(for: uri)
-      let snapshot = try await languageService.openSnapshotFromDiskOpenedInSourcekitd(
-        uri: uri,
-        fallbackSettingsAfterTimeout: false
-      )
-      openSnapshots[uri] = snapshot
-      return snapshot
+    if let cachedSnapshot = openSnapshots[uri] {
+      return cachedSnapshot
     }
-    return cachedSnapshot
+    let languageService = try await swiftLanguageService(for: uri)
+    let snapshot = try await languageService.openSnapshotFromDiskOpenedInSourcekitd(
+      uri: uri,
+      fallbackSettingsAfterTimeout: false
+    )
+    openSnapshots[uri] = snapshot
+    return snapshot
   }
 
   /// Closes all document snapshots that were opened by this ``OnDiskDocumentManager``.