Don’t fatalError for Fix-Its that make no changes

ahoppen · ahoppen · commit 34acdb02499c · 2024-04-04T11:05:53.000-07:00
diff --git a/Sources/SourceKitLSP/Swift/Diagnostic.swift b/Sources/SourceKitLSP/Swift/Diagnostic.swift
@@ -110,7 +110,8 @@ extension CodeAction {
     case (true, false):
       return "Insert '\(newText)'"
     case (true, true):
-      preconditionFailure("FixIt makes no changes")
+      logger.fault("Both oldText and newText of FixIt are empty")
+      return "Fix"
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,8 @@ extension CodeAction {`
`110`	`110`	`case (true, false):`
`111`	`111`	`return "Insert '\(newText)'"`
`112`	`112`	`case (true, true):`
`113`		`- preconditionFailure("FixIt makes no changes")`
	`113`	`+ logger.fault("Both oldText and newText of FixIt are empty")`
	`114`	`+ return "Fix"`
`114`	`115`	`}`
`115`	`116`	`}`
`116`	`117`	`}`