Skip to content

Commit 371b3f1

Browse files
committed
Remove FIXME comments to use in-memory file system
I don’t see any issue with using the real file system because it’s closer to what will be done in the real world and it makes it easier to debug issues because you can run `swift build` on the temporary directory.
1 parent 500cb1d commit 371b3f1

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

Tests/SKSwiftPMWorkspaceTests/SwiftPMWorkspaceTests.swift

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
106106
}
107107

108108
func testBasicSwiftArgs() async throws {
109-
// FIXME: should be possible to use InMemoryFileSystem.
110109
let fs = localFileSystem
111110
try await withTestScratchDir { tempDir in
112111
try fs.createFiles(
@@ -166,7 +165,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
166165
}
167166

168167
func testBuildSetup() async throws {
169-
// FIXME: should be possible to use InMemoryFileSystem.
170168
let fs = localFileSystem
171169
try await withTestScratchDir { tempDir in
172170
try fs.createFiles(
@@ -212,7 +210,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
212210
}
213211

214212
func testManifestArgs() async throws {
215-
// FIXME: should be possible to use InMemoryFileSystem.
216213
let fs = localFileSystem
217214
try await withTestScratchDir { tempDir in
218215
try fs.createFiles(
@@ -245,7 +242,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
245242
}
246243

247244
func testMultiFileSwift() async throws {
248-
// FIXME: should be possible to use InMemoryFileSystem.
249245
let fs = localFileSystem
250246
try await withTestScratchDir { tempDir in
251247
try fs.createFiles(
@@ -283,7 +279,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
283279
}
284280

285281
func testMultiTargetSwift() async throws {
286-
// FIXME: should be possible to use InMemoryFileSystem.
287282
let fs = localFileSystem
288283
try await withTestScratchDir { tempDir in
289284
try fs.createFiles(
@@ -349,7 +344,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
349344
}
350345

351346
func testUnknownFile() async throws {
352-
// FIXME: should be possible to use InMemoryFileSystem.
353347
let fs = localFileSystem
354348
try await withTestScratchDir { tempDir in
355349
try fs.createFiles(
@@ -385,7 +379,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
385379
}
386380

387381
func testBasicCXXArgs() async throws {
388-
// FIXME: should be possible to use InMemoryFileSystem.
389382
let fs = localFileSystem
390383
try await withTestScratchDir { tempDir in
391384
try fs.createFiles(
@@ -479,7 +472,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
479472
}
480473

481474
func testDeploymentTargetSwift() async throws {
482-
// FIXME: should be possible to use InMemoryFileSystem.
483475
let fs = localFileSystem
484476
try await withTestScratchDir { tempDir in
485477
try fs.createFiles(
@@ -522,7 +514,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
522514
}
523515

524516
func testSymlinkInWorkspaceSwift() async throws {
525-
// FIXME: should be possible to use InMemoryFileSystem.
526517
let fs = localFileSystem
527518
try await withTestScratchDir { tempDir in
528519
try fs.createFiles(
@@ -577,7 +568,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
577568
}
578569

579570
func testSymlinkInWorkspaceCXX() async throws {
580-
// FIXME: should be possible to use InMemoryFileSystem.
581571
let fs = localFileSystem
582572
try await withTestScratchDir { tempDir in
583573
try fs.createFiles(
@@ -627,7 +617,6 @@ final class SwiftPMWorkspaceTests: XCTestCase {
627617
}
628618

629619
func testSwiftDerivedSources() async throws {
630-
// FIXME: should be possible to use InMemoryFileSystem.
631620
let fs = localFileSystem
632621
try await withTestScratchDir { tempDir in
633622
try fs.createFiles(

0 commit comments

Comments
 (0)