Simplify getting MemberAccessExprSyntax.components

plemarquand · plemarquand · commit 46286262a192 · 2024-04-24T14:20:34.000-04:00
diff --git a/Sources/SourceKitLSP/Swift/SwiftTestingScanner.swift b/Sources/SourceKitLSP/Swift/SwiftTestingScanner.swift
@@ -364,8 +364,7 @@ fileprivate extension MemberAccessExprSyntax {
     if let declReferenceExpr = base?.as(DeclReferenceExprSyntax.self) {
       return [declReferenceExpr.baseName.text, declName.baseName.text]
     } else if let baseMemberAccessExpr = base?.as(MemberAccessExprSyntax.self) {
-      let baseBaseNames = baseMemberAccessExpr.components.dropLast()
-      return baseBaseNames + [baseMemberAccessExpr.declName.baseName.text, declName.baseName.text]
+      return baseMemberAccessExpr.components + [declName.baseName.text]
     }
 
     return [declName.baseName.text]

Original file line number	Diff line number	Diff line change
`@@ -364,8 +364,7 @@ fileprivate extension MemberAccessExprSyntax {`
`364`	`364`	`if let declReferenceExpr = base?.as(DeclReferenceExprSyntax.self) {`
`365`	`365`	`return [declReferenceExpr.baseName.text, declName.baseName.text]`
`366`	`366`	`} else if let baseMemberAccessExpr = base?.as(MemberAccessExprSyntax.self) {`
`367`		`- let baseBaseNames = baseMemberAccessExpr.components.dropLast()`
`368`		`- return baseBaseNames + [baseMemberAccessExpr.declName.baseName.text, declName.baseName.text]`
	`367`	`+ return baseMemberAccessExpr.components + [declName.baseName.text]`
`369`	`368`	`}`
`370`	`369`
`371`	`370`	`return [declName.baseName.text]`