Merge pull request #930 from ahoppen/ahoppen/log-reply

Increase log level for request responses

Author: ahoppen

Sources/LanguageServerProtocol/Request.swift

@@ -120,3 +120,26 @@ extension NotificationType {
     return AnyNotificationType(notification: self).forLogging
   }
 }
+
+fileprivate struct AnyResponseType: CustomLogStringConvertible {
+  let response: any ResponseType
+
+  var description: String {
+    return """
+      \(type(of: response))
+      \(response.prettyPrintJSON)
+      """
+  }
+
+  var redactedDescription: String {
+    return """
+      \(type(of: response))
+      """
+  }
+}
+
+extension ResponseType {
+  public var forLogging: CustomLogStringConvertibleWrapper {
+    return AnyResponseType(response: self).forLogging
+  }
+}

Sources/SourceKitLSP/SourceKitServer.swift

@@ -711,14 +711,24 @@ extension SourceKitServer: MessageHandler {
         reply(result)
         let endDate = Date()
         Task {
-          logger.debug(
-            """
-            Sending response (took \(endDate.timeIntervalSince(startDate) * 1000, privacy: .public)ms)
-            Response<\(R.method, privacy: .public)(\(id, privacy: .public))>(
-              \(String(describing: result))
+          switch result {
+          case .success(let response):
+            logger.log(
+              """
+              Succeeded (took \(endDate.timeIntervalSince(startDate) * 1000, privacy: .public)ms)
+              \(R.method, privacy: .public)
+              \(response.forLogging)
+              """
             )
-            """
-          )
+          case .failure(let error):
+             logger.log(
+              """
+              Failed (took \(endDate.timeIntervalSince(startDate) * 1000, privacy: .public)ms)
+              \(R.method, privacy: .public)(\(id, privacy: .public))
+              \(error.forLogging, privacy: .private)
+              """
+            ) 
+          }
         }
       }
     )