Fix issue that caused request cancellation after a timeout in tests to not work

ahoppen · ahoppen · commit c04518241d57 · 2025-04-07T18:28:41.000-07:00
We were calling `server.handle(notification:)`, which called directly into `SourceKitLSPServer` but request handling is implemented in `QueueBasedMessageHandler.handle(_:)`. Call that to ensure that we actually cancel requests after the test timeout.
diff --git a/Sources/SKTestSupport/TestSourceKitLSPClient.swift b/Sources/SKTestSupport/TestSourceKitLSPClient.swift
@@ -261,7 +261,7 @@ package final class TestSourceKitLSPClient: MessageHandler, Sendable {
           .failure(ResponseError.unknown("\(R.method) request timed out after \(defaultTimeoutDuration)"))
         )
       }
-      await server.handle(notification: CancelRequestNotification(id: requestID))
+      server.handle(CancelRequestNotification(id: requestID))
     }
     server.handle(request, id: requestID) { result in
       if replyOutstanding.takeValue() ?? false {

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ package final class TestSourceKitLSPClient: MessageHandler, Sendable {`
`261`	`261`	`.failure(ResponseError.unknown("\(R.method) request timed out after \(defaultTimeoutDuration)"))`
`262`	`262`	`)`
`263`	`263`	`}`
`264`		`- await server.handle(notification: CancelRequestNotification(id: requestID))`
	`264`	`+ server.handle(CancelRequestNotification(id: requestID))`
`265`	`265`	`}`
`266`	`266`	`server.handle(request, id: requestID) { result in`
`267`	`267`	`if replyOutstanding.takeValue() ?? false {`