Merge pull request #1697 from bnbarham/update-diagnose

Tweak diagnose bundle documentation

Author: bnbarham

Documentation/Diagnose Bundle.md

@@ -1,24 +1,26 @@
 # Diagnose Bundle
 
-The diagnose bundle is generated by the `sourcekit-lsp` diagnose command. It’s designed to contain to help SourceKit-LSP developers can diagnose and fix issues a user reports. The information in the diagnose bundle should be human readable so that users generating the bundle can determine whether they are willing to share the collected information with SourceKit-LSP developers.
+A diagnose bundle is designed to help SourceKit-LSP developers diagnose and fix reported issues.
+You can generate a diagnose bundle with:
+```sh
+sourcekit-lsp diagnose
+```
+
+And then attach the resulting `sourcekit-lsp-diagnose-*` bundle to any bug reports.
 
-The diagnose bundle contains the following information:
+You may want to inspect the bundle to determine whether you're willing to share the collected information. At a high level they contain:
 - Crash logs from SourceKit
   - From Xcode toolchains, just a stack trace.
   - For assert compilers (ie. nightly toolchains) also sometimes some source code that was currently compiled to cause the crash.
 - Log messages emitted by SourceKit
-  - We mark all information that may contain private information (source code, file names, …) as private in os_log so by default all of that will be redacted. Private logging can be enabled for SourceKit-LSP as described in [Enable Extended Logging](#enable-extended-logging). These extended log messages are also included in a sysdiagnose.
-  - On Linux and Windows, we currently don’t redact the private information, so users should always explicitly be asked before sharing these logs.
+  - We mark all information that may contain private information (source code, file names, …) as private by default, so all of that will be redacted. Private logging can be enabled for SourceKit-LSP as described in [Enable Extended Logging](#enable-extended-logging). On macOS these extended log messages are also included in a sysdiagnose.
 - Versions of Swift installed on your system
-  - We don’t consider this private information
 - If possible, a minimized project that caused SourceKit to crash
 - If possible, a minimized project that caused the Swift compiler to crash
-  - Both minimized projects contain user code and are thus considered private. Hence we need to explicitly prompt the user before sharing this information.
-  - As a future direction, it could be possible to remove any private information from the reduced examples by removing all comments and replacing all identifiers by obfuscated names.
 
 ## Enable Extended logging
 
-Extended logging of SourceKit-LSP is not enabled by default because it contains information about your source code, directory structure and similar potentially sensitive information. Instead, the logging system redacts that information. If you are comfortable with sharing such information, you can enable extended SourceKit-LSP’s extended logging, which improves the ability of SourceKit-LSP developers to understand and fix issues.
+Extended logging of SourceKit-LSP is not enabled by default because it contains information about your source code, directory structure, and similar potentially sensitive information. Instead, the logging system redacts that information. If you are comfortable with sharing such information, you can enable extended SourceKit-LSP’s extended logging, which improves the ability of SourceKit-LSP developers to understand and fix issues.
 
 ### macOS