Remove elements from outstandingRequests on crash

Otherwise, we can have a retain cycle where the `OutstandingRequest` keeps the `JSONRPCConnection` alive.

Also move the code that handled `outstandingRequests` out of the `Task` because `outstandingRequests` should only be accessed from `queue`.

Author: ahoppen

Sources/LanguageServerProtocolJSONRPC/JSONRPCConnection.swift

@@ -172,13 +172,14 @@ public final class JSONRPCConnection: Connection {
     )
 
     ioGroup.notify(queue: queue) { [weak self] in
-      guard let self = self else { return }
+      guard let self else { return }
+      for outstandingRequest in self.outstandingRequests.values {
+        outstandingRequest.replyHandler(LSPResult.failure(ResponseError.internalError("JSON-RPC Connection closed")))
+      }
+      self.outstandingRequests = [:]
+      self.receiveHandler = nil  // break retain cycle
       Task {
-        for outstandingRequest in self.outstandingRequests.values {
-          outstandingRequest.replyHandler(LSPResult.failure(ResponseError.internalError("JSON-RPC Connection closed")))
-        }
         await self.closeHandler?()
-        self.receiveHandler = nil  // break retain cycle
       }
     }