Merge pull request #1441 from ahoppen/log-index-exit-status

Log the exit status of prepare and index processes to the index log

Author: ahoppen

Sources/SKSupport/SwitchableProcessResultExitStatus.swift

@@ -21,6 +21,18 @@ public enum SwitchableProcessResultExitStatus {
   case abnormal(exception: UInt32)
   /// The process was terminated due to a signal.
   case signalled(signal: Int32)
+
+  /// A description of the exit status that can be used in sentences like `Finished with <exit status description>`.
+  public var description: String {
+    switch self {
+    case .terminated(code: let code):
+      "exit code \(code)"
+    case .abnormal(exception: let exception):
+      "exception \(exception)"
+    case .signalled(signal: let signal):
+      "signal \(signal)"
+    }
+  }
 }
 
 extension ProcessResult.ExitStatus {

Sources/SKSwiftPMWorkspace/SwiftPMBuildSystem.swift

@@ -631,8 +631,9 @@ extension SwiftPMBuildSystem: SKCore.BuildSystem {
         stderr: { stderrHandler.handleDataFromPipe(Data($0)) }
       )
     )
-    logMessageToIndexLog(logID, "Finished in \(start.duration(to: .now))")
-    switch result.exitStatus.exhaustivelySwitchable {
+    let exitStatus = result.exitStatus.exhaustivelySwitchable
+    logMessageToIndexLog(logID, "Finished with \(exitStatus.description) in \(start.duration(to: .now))")
+    switch exitStatus {
     case .terminated(code: 0):
       break
     case .terminated(code: let code):

Sources/SemanticIndex/UpdateIndexStoreTaskDescription.swift

@@ -370,10 +370,9 @@ public struct UpdateIndexStoreTaskDescription: IndexTaskDescription {
         )
       )
     }
-
-    logMessageToIndexLog(logID, "Finished in \(start.duration(to: .now))")
-
-    switch result.exitStatus.exhaustivelySwitchable {
+    let exitStatus = result.exitStatus.exhaustivelySwitchable
+    logMessageToIndexLog(logID, "Finished with \(exitStatus.description) in \(start.duration(to: .now))")
+    switch exitStatus {
     case .terminated(code: 0):
       break
     case .terminated(code: let code):