Don’t fatalError if applying an edit in sourcekitd fails

ahoppen · ahoppen · commit f41feb7d2829 · 2024-04-04T11:05:53.000-07:00
diff --git a/Sources/SourceKitLSP/Swift/SwiftLanguageService.swift b/Sources/SourceKitLSP/Swift/SwiftLanguageService.swift
@@ -518,7 +518,12 @@ extension SwiftLanguageService {
       do {
         _ = try await self.sourcekitd.send(req, fileContents: nil)
       } catch {
-        fatalError("failed to apply edit")
+        logger.fault(
+          """
+          failed to replace \(edit.range.lowerBound.utf8Offset):\(edit.range.upperBound.utf8Offset) by \
+          '\(edit.replacement)' in sourcekitd
+          """
+        )
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,12 @@ extension SwiftLanguageService {`
`518`	`518`	`do {`
`519`	`519`	`_ = try await self.sourcekitd.send(req, fileContents: nil)`
`520`	`520`	`} catch {`
`521`		`- fatalError("failed to apply edit")`
	`521`	`+ logger.fault(`
	`522`	`+ """`
	`523`	`+ failed to replace \(edit.range.lowerBound.utf8Offset):\(edit.range.upperBound.utf8Offset) by \`
	`524`	`+ '\(edit.replacement)' in sourcekitd`
	`525`	`+ """`
	`526`	`+ )`
`522`	`527`	`}`
`523`	`528`	`}`
`524`	`529`