Skip to content

Commit 13e2888

Browse files
committed
[test] Parameterize two host tools index tests
Use Swift Testing parameterization to test different run destinations.
1 parent 9626780 commit 13e2888

File tree

1 file changed

+4
-18
lines changed

1 file changed

+4
-18
lines changed

Tests/SWBBuildSystemTests/HostBuildToolBuildOperationTests.swift

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -158,21 +158,6 @@ fileprivate struct HostBuildToolBuildOperationTests: CoreBasedTests {
158158
}
159159
}
160160

161-
@Test(.requireSDKs(.macOS))
162-
func hostToolsAndDependenciesAreBuiltDuringIndexingPreparation_Mac() async throws {
163-
try await testHostToolsAndDependenciesAreBuiltDuringIndexingPreparation(destination: .anyMac)
164-
}
165-
166-
@Test(.requireSDKs(.macOS, .iOS))
167-
func hostToolsAndDependenciesAreBuiltDuringIndexingPreparation_MacCatalyst() async throws {
168-
try await testHostToolsAndDependenciesAreBuiltDuringIndexingPreparation(destination: .anyMacCatalyst)
169-
}
170-
171-
@Test(.requireSDKs(.macOS, .iOS))
172-
func hostToolsAndDependenciesAreBuiltDuringIndexingPreparation_iOS() async throws {
173-
try await testHostToolsAndDependenciesAreBuiltDuringIndexingPreparation(destination: .anyiOSDevice)
174-
}
175-
176161
private func withHostToolsPackages(
177162
clients: TestProject...,
178163
body: (BuildOperationTester, TestWorkspace) async throws -> Void
@@ -346,6 +331,7 @@ fileprivate struct HostBuildToolBuildOperationTests: CoreBasedTests {
346331
}
347332
}
348333

334+
@Test(.requireSDKs(.macOS, .iOS), arguments: [RunDestinationInfo.anyMac, .anyMacCatalyst, .anyiOSDevice])
349335
func testHostToolsAndDependenciesAreBuiltDuringIndexingPreparation(destination: RunDestinationInfo) async throws {
350336
let testProject = try await TestProject(
351337
"aProject",
@@ -452,10 +438,10 @@ fileprivate struct HostBuildToolBuildOperationTests: CoreBasedTests {
452438
}
453439
}
454440

455-
@Test(.requireSDKs(.macOS))
456-
func testHostToolsAndDependenciesAreBuiltDuringIndexingPreparationForPackage() async throws {
441+
@Test(.requireSDKs(.macOS, .iOS), arguments: [RunDestinationInfo.anyMac, .anyMacCatalyst, .anyiOSDevice])
442+
func testHostToolsAndDependenciesAreBuiltDuringIndexingPreparationForPackage(destination: RunDestinationInfo) async throws {
457443
try await withHostToolsPackages { tester, testWorkspace in
458-
try await tester.checkIndexBuild(prepareTargets: testWorkspace.projects[1].targets.map(\.guid), workspaceOperation: false, runDestination: .anyMac, persistent: true) { results in
444+
try await tester.checkIndexBuild(prepareTargets: testWorkspace.projects[1].targets.map(\.guid), workspaceOperation: false, runDestination: destination, persistent: true) { results in
459445
results.checkNoDiagnostics()
460446

461447
results.checkTaskExists(.matchTargetName("HostTool"), .matchRuleType("Ld"))

0 commit comments

Comments
 (0)