Merge pull request #437 from swiftlang/bg/add-new-libcpp-flag

Add new libcxx flag for disabling container overflow checks for Asan.

Author: thetruestblue

Sources/SWBUniversalPlatform/Specs/Clang LLVM 1.0.xcspec

@@ -2736,6 +2736,7 @@
                     YES = ();
                     NO = (
                         "-D_LIBCPP_HAS_NO_ASAN",
+                        "-D_LIBCPP_HAS_ASAN=0",
                     );
                 };
                 Condition = "$(CLANG_ADDRESS_SANITIZER)";

Tests/SWBTaskConstructionTests/TaskConstructionTests.swift

@@ -4135,7 +4135,7 @@ fileprivate struct TaskConstructionTests: CoreBasedTests {
                     // There should be one CompileC task, which includes the ASan option, and which puts its output in a -asan directory.
                     results.checkTask(.matchTarget(target), .matchRuleType("CompileC")) { task in
                         task.checkRuleInfo([.equal("CompileC"), .equal("\(SRCROOT)/build/aProject.build/Debug/\(targetName).build/Objects-normal-asan/x86_64/SourceFile.o"), .suffix("SourceFile.m"), .any, .any, .any, .any])
-                        task.checkCommandLineContains(["\(core.developerPath.path.str)/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang", "-fsanitize=address", "-D_LIBCPP_HAS_NO_ASAN", "\(SRCROOT)/build/aProject.build/Debug/\(targetName).build/Objects-normal-asan/x86_64/SourceFile.o"])
+                        task.checkCommandLineContains(["\(core.developerPath.path.str)/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang", "-fsanitize=address", "-D_LIBCPP_HAS_NO_ASAN", "-D_LIBCPP_HAS_ASAN=0", "\(SRCROOT)/build/aProject.build/Debug/\(targetName).build/Objects-normal-asan/x86_64/SourceFile.o"])
                     }
 
                     // There should be one CompileSwiftSources task, which includes the ASan option, and which puts its output in a -asan directory.