Skip to content

Commit 5d9f6d9

Browse files
committed
Change call to Core.delegate.error() to self.errors.append()
The Core's diagnostics delegate has been made immutable by this point, so if an error were ever emitted here it would crash the build service.
1 parent 3c541cc commit 5d9f6d9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Sources/SWBCore/Settings/Settings.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4590,7 +4590,7 @@ private class SettingsBuilder {
45904590
] {
45914591
let macroName = "\(BuiltinMacros.ENABLE_DEFAULT_SEARCH_PATHS.name)_IN_\(searchPathMacro.name)"
45924592
guard let macro = userNamespace.lookupMacroDeclaration(macroName) as? BooleanMacroDeclaration else {
4593-
core.delegate.error("internal error: Build setting \(macroName) is not of boolean type")
4593+
self.errors.append("internal error: Build setting \(macroName) is not of boolean type")
45944594
continue
45954595
}
45964596
// Note that this implies if the macro is unset or set to empty then it defaults to YES, which is the opposite of most macros, but probably fine for this very niche functionality. If this becomes an issue then we should declare all of these macros in CoreBuildSystem.xcspec with default values of YES, or maybe $(ENABLE_DEFAULT_SEARCH_PATHS).

0 commit comments

Comments
 (0)