Skip to content

Commit 7a32541

Browse files
[TEST-ONLY] Disable explicitModulesEnvironment() test
Test sets global environment that interferes other tests that are running at the same time. Bug tracked: #835 Also drop the flaky tests label in Xcode cloud for compilation caching tests that are likely all related the change of the environment.
1 parent 7aea4ee commit 7a32541

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

Tests/SWBBuildSystemTests/ClangCompilationCachingTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import SWBTestSupport
1919
import SWBUtil
2020

2121
@Suite(.skipHostOS(.windows, "Windows platform has no CAS support yet"),
22-
.requireDependencyScannerPlusCaching, .skipInXcodeCloud("flaky tests"), .requireXcode26())
22+
.requireDependencyScannerPlusCaching, .requireXcode26())
2323
fileprivate struct ClangCompilationCachingTests: CoreBasedTests {
2424
let canUseCASPlugin: Bool
2525
let canUseCASPruning: Bool

Tests/SWBBuildSystemTests/ClangExplicitModulesTests.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,8 @@ fileprivate struct ClangExplicitModulesTests: CoreBasedTests {
373373
}
374374
}
375375

376-
@Test(.requireSDKs(.macOS))
376+
@Test(.requireSDKs(.macOS), .disabled("setting global environment interferes concurrent tests"),
377+
.bug("https://github.com/swiftlang/swift-build/issues/835"))
377378
func explicitModulesEnvironment() async throws {
378379
try await withTemporaryDirectory { tmpDirPath in
379380
let testWorkspace = TestWorkspace(

Tests/SWBBuildSystemTests/ClangModuleVerifierTests.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,7 @@ fileprivate struct ClangModuleVerifierTests: CoreBasedTests {
191191
}
192192
}
193193

194-
@Test(.requireSDKs(.macOS), .requireClangFeatures(.wSystemHeadersInModule), .requireDependencyScannerPlusCaching,
195-
.skipInXcodeCloud("flaky tests"), .requireXcode26())
194+
@Test(.requireSDKs(.macOS), .requireClangFeatures(.wSystemHeadersInModule), .requireDependencyScannerPlusCaching, .requireXcode26())
196195
func cachedBuild() async throws {
197196
try await withTemporaryDirectory { (tmpDirPath: Path) in
198197
let archs = ["arm64", "x86_64"]

Tests/SWBBuildSystemTests/SwiftCompilationCachingTests.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ import SWBUtil
1919
import SWBTaskExecution
2020
import SWBProtocol
2121

22-
@Suite(.requireSwiftFeatures(.compilationCaching),
23-
.skipInXcodeCloud("flaky tests"), .requireXcode26())
22+
@Suite(.requireSwiftFeatures(.compilationCaching), .requireXcode26())
2423
fileprivate struct SwiftCompilationCachingTests: CoreBasedTests {
2524
@Test(.requireSDKs(.iOS))
2625
func swiftCachingSimple() async throws {

0 commit comments

Comments
 (0)