Update FilePathResovler so the product references can use a build setting

daveinglis · daveinglis · commit 908179daa6cb · 2025-09-11T12:48:43.000-04:00
diff --git a/Sources/SWBCore/ProjectModel/FilePathResolver.swift b/Sources/SWBCore/ProjectModel/FilePathResolver.swift
@@ -84,7 +84,7 @@ public final class FilePathResolver: Sendable
             }
 
             // FIXME: We are relying on the product reference name being constant here. This is currently true, given how our path resolver works, but it is possible to construct an Xcode project for which this doesn't work (Xcode doesn't, however, handle that situation very well). We should resolve this: <rdar://problem/29410050> Swift Build doesn't support product references with non-constant basenames
-            return sourceTreePath.join(productReference.name)
+            return sourceTreePath.join(scope.evaluate(scope.table.namespace.parseString(productReference.name)))
 
         default:
             preconditionFailure("Cannot resolve the path for a \(type(of: reference))")

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public final class FilePathResolver: Sendable`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`// FIXME: We are relying on the product reference name being constant here. This is currently true, given how our path resolver works, but it is possible to construct an Xcode project for which this doesn't work (Xcode doesn't, however, handle that situation very well). We should resolve this: <rdar://problem/29410050> Swift Build doesn't support product references with non-constant basenames`
`87`		`- return sourceTreePath.join(productReference.name)`
	`87`	`+ return sourceTreePath.join(scope.evaluate(scope.table.namespace.parseString(productReference.name)))`
`88`	`88`
`89`	`89`	`default:`
`90`	`90`	`preconditionFailure("Cannot resolve the path for a \(type(of: reference))")`