Remove customized missing framework diagnostics

This is some very old code that modifies the wording of some diagnostics from the compiler and linker that are emitted when a framework or module is not found. It's not that useful, adds significant complexity and overhead, and would require significant refactoring to make some of the call sites properly asynchronous. We don't really need this functionality anymore, so remove it.

Author: jakepetroules

Sources/SWBBuildService/Messages.swift

@@ -104,7 +104,7 @@ private struct AppleSystemFrameworkNamesHandler: MessageHandler {
         guard let buildService = request.service as? BuildService else {
             throw StubError.error("service object is not of type BuildService")
         }
-        return try await StringListResponse(Array(buildService.sharedCore(developerPath: message.effectiveDeveloperPath).appleSystemFrameworkNames()))
+        return try await StringListResponse([])
     }
 }
 

Sources/SWBCore/CMakeLists.txt

@@ -82,7 +82,6 @@ add_library(SWBCore
   MacroConfigFileLoader.swift
   MacroEvaluationExtensions.swift
   MacroExpressionSourceExtensions.swift
-  MissingFrameworkDiagnostics.swift
   OnDemandResources.swift
   OptimizationRemarks.swift
   PlannedNode.swift

Sources/SWBCore/Core.swift

@@ -542,10 +542,6 @@ public final class Core: Sendable {
         return result
     }
 
-    public func appleSystemFrameworkNames() throws -> Set<String> {
-        Set(sdkRegistry.allSDKs.flatMap { sdk in sdk.knownFrameworkNames })
-    }
-
     public func productTypeSupportsMacCatalyst(productTypeIdentifier: String) throws -> Bool {
         do {
             let productTypeSpec = try specRegistry.getSpec(productTypeIdentifier, domain: "macosx") as ProductTypeSpec

Sources/SWBCore/Extensions/SDKRegistryExtension.swift

@@ -22,7 +22,6 @@ public struct SDKRegistryExtensionPoint: ExtensionPoint {
 
 public protocol SDKRegistryExtension: Sendable {
     var supportedSDKCanonicalNameSuffixes: Set<String> { get }
-    func additionalKnownFrameworkDirectories(for sdkCanonicalName: String, sdkPath: Path) -> [Path]
 
     func additionalSDKs(platformRegistry: PlatformRegistry) async -> [(path: Path, platform: Platform?, data: [String: PropertyListItem])]
 }
@@ -32,10 +31,6 @@ extension SDKRegistryExtension {
         []
     }
 
-    public func additionalKnownFrameworkDirectories(for sdkCanonicalName: String, sdkPath: Path) -> [Path] {
-        []
-    }
-
     public func additionalSDKs(platformRegistry: PlatformRegistry) async -> [(path: Path, platform: Platform?, data: [String: PropertyListItem])] {
         []
     }