Skip to content

Commit cb89d38

Browse files
committed
Pass through a couple missing parameters when creating derived build requests
Noticed this; fix it before it bites someone later...
1 parent 7836ba6 commit cb89d38

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

Sources/SWBCore/BuildRequest.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ extension BuildRequest {
323323
case .buildRequest:
324324
dependencyScope = .buildRequest
325325
}
326-
try self.init(parameters: parameters, buildTargets: payload.configuredTargets.map{ try BuildRequest.BuildTargetInfo(from: $0, defaultParameters: parameters, workspace: workspace) }, dependencyScope: dependencyScope, continueBuildingAfterErrors: payload.continueBuildingAfterErrors, hideShellScriptEnvironment: payload.hideShellScriptEnvironment, useParallelTargets: payload.useParallelTargets, useImplicitDependencies: payload.useImplicitDependencies, useDryRun: payload.useDryRun, showNonLoggedProgress: payload.showNonLoggedProgress, recordBuildBacktraces: payload.recordBuildBacktraces, generatePrecompiledModulesReport: payload.generatePrecompiledModulesReport, buildDescriptionID: payload.buildDescriptionID.map(BuildDescriptionID.init), qos: qos, buildPlanDiagnosticsDirPath: payload.buildPlanDiagnosticsDirPath, buildCommand: buildCommand, schemeCommand: payload.schemeCommand?.coreRepresentation, containerPath: payload.containerPath, jsonRepresentation: payload.jsonRepresentation)
326+
try self.init(parameters: parameters, buildTargets: payload.configuredTargets.map{ try BuildRequest.BuildTargetInfo(from: $0, defaultParameters: parameters, workspace: workspace) }, dependencyScope: dependencyScope, continueBuildingAfterErrors: payload.continueBuildingAfterErrors, hideShellScriptEnvironment: payload.hideShellScriptEnvironment, useParallelTargets: payload.useParallelTargets, useImplicitDependencies: payload.useImplicitDependencies, useDryRun: payload.useDryRun, enableStaleFileRemoval: nil, showNonLoggedProgress: payload.showNonLoggedProgress, recordBuildBacktraces: payload.recordBuildBacktraces, generatePrecompiledModulesReport: payload.generatePrecompiledModulesReport, buildDescriptionID: payload.buildDescriptionID.map(BuildDescriptionID.init), qos: qos, buildPlanDiagnosticsDirPath: payload.buildPlanDiagnosticsDirPath, buildCommand: buildCommand, schemeCommand: payload.schemeCommand?.coreRepresentation, containerPath: payload.containerPath, jsonRepresentation: payload.jsonRepresentation)
327327
}
328328

329329
/// Whether the build request _explicitly_ contains the specified `target`.

Sources/SWBTestSupport/BuildOperationTester.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ extension BuildRequest {
5050
useDryRun: useDryRun,
5151
enableStaleFileRemoval: enableStaleFileRemoval,
5252
showNonLoggedProgress: showNonLoggedProgress,
53+
recordBuildBacktraces: recordBuildBacktraces,
54+
generatePrecompiledModulesReport: generatePrecompiledModulesReport,
5355
buildDescriptionID: buildDescriptionID,
5456
qos: qos,
5557
buildPlanDiagnosticsDirPath: buildPlanDiagnosticsDirPath,

0 commit comments

Comments
 (0)