Ensure the build description is regenerated when entitlements change

This avoids incorrectly diagnosing an entitlements change during the build.

Author: owenv

Sources/SWBCore/SpecImplementations/Tools/ProductPackaging.swift

@@ -170,6 +170,10 @@ public final class ProductPackagingToolSpec : GenericCommandLineToolSpec, SpecId
 
         // Create the task action, and then the task.
         let action = delegate.taskActionCreationDelegate.createProcessProductEntitlementsTaskAction(scope: cbc.scope, mergedEntitlements: entitlements, entitlementsVariant: entitlementsVariant, destinationPlatformName: platform.name, entitlementsFilePath: codeSignEntitlementsInput?.absolutePath, fs: fs)
+        // The action records a timestamp representing the last modification date of the entitlements file, so changes to the input must invalidate the build description.
+        if let path = codeSignEntitlementsInput?.absolutePath {
+            delegate.access(path: path)
+        }
 
         delegate.createTask(type: self, ruleInfo: ["ProcessProductPackaging", codeSignEntitlementsInput?.absolutePath.str ?? "", outputPath.str], commandLine: commandLine, additionalOutput: additionalOutput, environment: environmentFromSpec(cbc, delegate), workingDirectory: cbc.producer.defaultWorkingDirectory, inputs: inputs.map(\.absolutePath), outputs: [ outputPath ], action: action, execDescription: resolveExecutionDescription(cbc, delegate), enableSandboxing: enableSandboxing)
     }

Tests/SWBBuildSystemTests/CodeSigningBuildOperationTests.swift

@@ -0,0 +1,79 @@
+//===----------------------------------------------------------------------===//
+//
+// This source file is part of the Swift open source project
+//
+// Copyright (c) 2025 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See http://swift.org/LICENSE.txt for license information
+// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+
+import SWBBuildSystem
+import SWBCore
+import SWBTaskExecution
+import SWBTestSupport
+import SWBUtil
+import Testing
+
+@Suite
+fileprivate struct CodeSigningBuildOperationTests: CoreBasedTests {
+    @Test(.requireSDKs(.macOS))
+    func entitlementsModificationInvalidatesBuildDescription() async throws {
+        try await withTemporaryDirectory { tmpDirPath in
+            let testProject = TestProject(
+                "aProject",
+                sourceRoot: tmpDirPath,
+                groupTree: TestGroup(
+                    "SomeFiles", path: "Sources",
+                    children: [
+                        TestFile("AppSource.m"),
+                    ]),
+                buildConfigurations: [
+                    TestBuildConfiguration( "Debug", buildSettings: [
+                        "COPY_PHASE_STRIP": "NO",
+                        "DEBUG_INFORMATION_FORMAT": "dwarf",
+                        "GENERATE_INFOPLIST_FILE": "YES",
+                        "PRODUCT_NAME": "$(TARGET_NAME)",
+                        "CODE_SIGN_IDENTITY": "-",
+                        "CODE_SIGN_ENTITLEMENTS": "Entitlements.entitlements",
+                        "SDKROOT": "macosx",
+                        "SUPPORTED_PLATFORMS": "macosx",
+                    ]),
+                ],
+                targets: [
+                    TestStandardTarget(
+                        "AppTarget",
+                        type: .application,
+                        buildPhases: [
+                            TestSourcesBuildPhase([
+                                "AppSource.m",
+                            ]),
+                        ],
+                    ),
+                ]
+            )
+
+            let tester = try await BuildOperationTester(getCore(), testProject, simulated: false)
+            let SRCROOT = tester.workspace.projects[0].sourceRoot.str
+
+            try tester.fs.createDirectory(Path(SRCROOT).join("Sources"), recursive: true)
+            try tester.fs.write(Path(SRCROOT).join("Sources/AppSource.m"), contents: "int main() { return 0; }")
+            try await tester.fs.writePlist(Path(SRCROOT).join("Entitlements.entitlements"), .plDict([:]))
+
+            try await tester.checkBuild(parameters: BuildParameters(configuration: "Debug"), runDestination: .macOS, persistent: true, signableTargets: ["AppTarget"]) { results in
+                results.checkNoDiagnostics()
+            }
+
+            // Modify the entitlements in between builds, but make no other changes which would invalidate the build description.
+            try tester.fs.touch(Path(SRCROOT).join("Entitlements.entitlements"))
+
+            // A subsequent build should succeed, and should NOT diagnose entitlements modification during the build.
+            try await tester.checkBuild(parameters: BuildParameters(configuration: "Debug"), runDestination: .macOS, persistent: true, signableTargets: ["AppTarget"]) { results in
+                results.checkNoDiagnostics()
+            }
+        }
+    }
+}
+