Avoid error if missing xattr support #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building on a darwin host (e.g. macOS) using a file-system that doesn't support xattrs (e.g. tmpfs) swift-build would fail trying to set the "CreatedByBuildSystem" xattribute. This commit changes swift-build to warn instead, allowing the build to complete.
rauhul
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
Sources/SWBTaskExecution/TaskActions/CreateBuildDirectoryTaskAction.swift
Outdated
Show resolved
Hide resolved
| // Warn on darwin if we are unable to set the "CreateByBuildSystem" | ||
| // attribute | ||
| do { | ||
| try fs.setCreatedByBuildSystemAttribute(directoryPath) |
Collaborator
There was a problem hiding this comment.
The other alternative is we just use try? and drop the diagnostic entirely. @owenv, what do you think?
The reason I suggested the if-Darwin to @rauhul is because we'd otherwise have to change tests to ignore this message since most Linux build environments are using containers, which use tmpfs, which don't support xattrs.
Collaborator
There was a problem hiding this comment.
Does the xattr still control whether we're willing to clean a directory? If yes, it could be quite confusing that we never told the user about the fact that we couldn't set it.
Collaborator
There was a problem hiding this comment.
There's a setting to allow deleting directories without the attr, but I think this warning still makes sense
owenv
approved these changes
Jul 31, 2025
Member
Author
|
@swift-ci test |
jakepetroules
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on a darwin host (e.g. macOS) using a file-system that doesn't support xattrs (e.g. tmpfs) swift-build would fail trying to set the "CreatedByBuildSystem" xattribute. This commit changes swift-build to warn instead, allowing the build to complete.