Upstream trivial diffs #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
aciidgh,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
owenv
approved these changes
Jul 31, 2025
neonichu
approved these changes
Jul 31, 2025
Collaborator
Author
|
@swift-ci test |
jakepetroules
force-pushed
the
eng/PR-upstream-diffs-release/6.2
branch
from
82ba595 to
c5a13c6
Compare
Collaborator
Author
|
@swift-ci test |
withSerializationContext needs to be exposed to tests, and BuildService.run needs to build and do so without warnings regardless of whether USE_STATIC_PLUGIN_INITIALIZATION is set. EXCLUDED_RECURSIVE_SEARCH_PATH_SUBDIRECTORIES's DefaultValue was duplicated in an incorrect merge conflict resolution. STRING_CATALOG_GENERATE_SYMBOLS was missing from the CoreBuildSystem xcspec.
jakepetroules
force-pushed
the
eng/PR-upstream-diffs-release/6.2
branch
from
c5a13c6 to
8d34207
Compare
Collaborator
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withSerializationContext needs to be exposed to tests, and BuildService.run needs to build and do so without warnings regardless of whether USE_STATIC_PLUGIN_INITIALIZATION is set. EXCLUDED_RECURSIVE_SEARCH_PATH_SUBDIRECTORIES's DefaultValue was duplicated in an incorrect merge conflict resolution. STRING_CATALOG_GENERATE_SYMBOLS was missing from the CoreBuildSystem xcspec.