Still emit per-task C diagnostics if errors are requested #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to group diagnostics to avoid duplicates, but also avoid building the entire target if we already know about errors. So for C compiles specifically, we'll continue emitting diagnostics per-task if errors are enabled. Additionally, this PR fixes up the signature data related to dependency diagnostics. The `ValidateDependencies` task needs to depend on the `MODULE_DEPENDENCIES` build setting, but the Swift planning task shouldn't anymore. For Clang tasks, this is now also dependent on whether errors are enabled or not.
neonichu
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic and
owenv
as code owners
|
@swift-ci please test |
owenv
approved these changes
Aug 4, 2025
| delegate.error("Error serializing \(payload): \(error)") | ||
| return | ||
| } | ||
| guard let signature = String(data: jsonData, encoding: .utf8) else { |
There was a problem hiding this comment.
I always use String(decoding: jsonData, as: UTF8.self) which is non-failable
|
Had some offline discussion about this and we decided that this isn't really worth it considering it actually needs more work to make sure rebuilds work well in all cases. Instead I opened #710 to keep the signature fixes that were included in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to group diagnostics to avoid duplicates, but also avoid building the entire target if we already know about errors. So for C compiles specifically, we'll continue emitting diagnostics per-task if errors are enabled.
Additionally, this PR fixes up the signature data related to dependency diagnostics. The
ValidateDependenciestask needs to depend on theMODULE_DEPENDENCIESbuild setting, but the Swift planning task shouldn't anymore. For Clang tasks, this is now also dependent on whether errors are enabled or not.