Fix task signatures for module dependencies #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ValidateDependencies` needs to include the context as part of its signature - Swift tasks no longer need to do this since they don't deal in module dependencies directly, only emitting a data file for use by `ValidateDependencies`
neonichu
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic and
owenv
as code owners
|
@swift-ci please test |
|
@swift-ci please test macOS |
owenv
approved these changes
Aug 6, 2025
|
It seems like the Windows GH action is just broken right now for unrelated reasons. Since the Swift CI one is passing, I think this is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidateDependenciesneeds to include the context as part of its signatureValidateDependencies