build: remove CMARK_SHARED and CMARK_STATIC

Prefer to use the standard `BUILD_SHARED_LIBS` option to control the
library type that we are building. Build a single instance of the
library. This allows for better control of the library usage in a larger
project. See the following blog post for the recommendation:
https://alexreinking.com/blog/building-a-dual-shared-and-static-library-with-cmake.html

Author: compnerd

CMakeLists.txt

@@ -64,8 +64,6 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_BINARY_DIR}")
     message(FATAL_ERROR "Do not build in-source.\nPlease remove CMakeCache.txt and the CMakeFiles/ directory.\nThen: mkdir build ; cd build ; cmake .. ; make")
 endif()
 
-option(CMARK_STATIC "Build static libcmark-gfm library" ON)
-option(CMARK_SHARED "Build shared libcmark-gfm library" ON)
 option(CMARK_LIB_FUZZER "Build libFuzzer fuzzing harness" OFF)
 option(CMARK_THREADING "Add locks around static accesses" OFF)
 
@@ -105,24 +103,14 @@ if(NOT CMAKE_SYSTEM_NAME STREQUAL Windows)
 endif()
 if(BUILD_TESTING)
   add_subdirectory(test testdir)
-  if(CMARK_SHARED OR CMARK_STATIC)
-    add_subdirectory(api_test)
-  endif()
+  add_subdirectory(api_test)
 endif()
 if(CMARK_FUZZ_QUADRATIC)
   add_subdirectory(fuzz)
 endif()
 
-set(CMARK_TARGETS)
-if(CMARK_SHARED)
-  list(APPEND CMARK_TARGETS libcmark-gfm)
-  list(APPEND CMARK_TARGETS libcmark-gfm-extensions)
-endif()
-if(CMARK_STATIC)
-  list(APPEND CMARK_TARGETS libcmark-gfm_static)
-  list(APPEND CMARK_TARGETS libcmark-gfm-extensions_static)
-endif()
-export(TARGETS ${CMARK_TARGETS} FILE cmark-gfmConfig.cmake)
+export(TARGETS libcmark-gfm libcmark-gfm-extensions
+  FILE cmark-gfmConfig.cmake)
 
 if(NOT CMAKE_BUILD_TYPE)
   set(CMAKE_BUILD_TYPE "Release" CACHE STRING

api_test/CMakeLists.txt

@@ -10,14 +10,12 @@ include_directories(
   ${PROJECT_SOURCE_DIR}/extensions/include
   ${PROJECT_BINARY_DIR}/extensions
 )
-if(CMARK_SHARED)
-  target_link_libraries(api_test libcmark-gfm-extensions libcmark-gfm)
-else()
-  target_link_libraries(api_test libcmark-gfm-extensions_static libcmark-gfm_static)
-endif()
+target_link_libraries(api_test PRIVATE
+  libcmark-gfm
+  libcmark-gfm-extensions)
 
 add_test(NAME api_test COMMAND api_test)
-if(WIN32 AND CMARK_SHARED)
+if(WIN32 AND BUILD_SHARED_LIBS)
   set_tests_properties(api_test PROPERTIES
     ENVIRONMENT "PATH=$<TARGET_FILE_DIR:libcmark-gfm>;$<TARGET_FILE_DIR:libcmark-gfm-extensions>;$ENV{PATH}")
 endif()

extensions/CMakeLists.txt

@@ -1,61 +1,36 @@
 set(LIBRARY "libcmark-gfm-extensions")
-set(STATICLIBRARY "libcmark-gfm-extensions_static")
-set(LIBRARY_SOURCES
-    core-extensions.c
-    table.c
-    strikethrough.c
-    autolink.c
-    tagfilter.c
-    ext_scanners.c
-    ext_scanners.re
-    ext_scanners.h
-    tasklist.c
-   )
 
 include_directories(include)
 
-if (CMARK_SHARED)
-  add_library(${LIBRARY} SHARED ${LIBRARY_SOURCES})
+add_library(${LIBRARY}
+  autolink.c
+  core-extensions.c
+  ext_scanners.c
+  ext_scanners.h
+  ext_scanners.re
+  strikethrough.c
+  table.c
+  tagfilter.c
+  tasklist.c)
+target_compile_definitions(${LIBRARY} PUBLIC
+  $<$<NOT:$<BOOL:${BUILD_SHARED_LIBS}>>:CMARK_GFM_STATIC_DEFINE>)
 
-  set_target_properties(${LIBRARY} PROPERTIES
-    OUTPUT_NAME "cmark-gfm-extensions"
-    DEFINE_SYMBOL "libcmark_gfm_EXPORTS"
-    SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}.gfm.${PROJECT_VERSION_GFM}
-    VERSION ${PROJECT_VERSION})
+set_target_properties(${LIBRARY} PROPERTIES
+  OUTPUT_NAME "cmark-gfm-extensions"
+  DEFINE_SYMBOL "libcmark_gfm_EXPORTS"
+  SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}.gfm.${PROJECT_VERSION_GFM}
+  VERSION ${PROJECT_VERSION})
 
-  set_property(TARGET ${LIBRARY}
-    APPEND PROPERTY MACOSX_RPATH true)
+set_property(TARGET ${LIBRARY}
+  APPEND PROPERTY MACOSX_RPATH true)
 
-  # Avoid name clash between PROGRAM and LIBRARY pdb files.
-  set_target_properties(${LIBRARY} PROPERTIES PDB_NAME cmark-gfm-extensions_dll)
+# Avoid name clash between PROGRAM and LIBRARY pdb files.
+set_target_properties(${LIBRARY} PROPERTIES PDB_NAME cmark-gfm-extensions_dll)
 
-  list(APPEND CMARK_INSTALL ${LIBRARY})
-  target_link_libraries(${LIBRARY} libcmark-gfm)
+list(APPEND CMARK_INSTALL ${LIBRARY})
+target_link_libraries(${LIBRARY} libcmark-gfm)
 
-endif()
 
-if (CMARK_STATIC)
-  add_library(${STATICLIBRARY} STATIC ${LIBRARY_SOURCES})
-  target_compile_definitions(${STATICLIBRARY} PUBLIC
-    CMARK_GFM_STATIC_DEFINE)
-  target_link_libraries(${STATICLIBRARY} PRIVATE
-    libcmark-gfm)
-
-  set_target_properties(${STATICLIBRARY} PROPERTIES
-    POSITION_INDEPENDENT_CODE ON)
-
-  if (MSVC)
-    set_target_properties(${STATICLIBRARY} PROPERTIES
-      OUTPUT_NAME "cmark-gfm-extensions_static"
-      VERSION ${PROJECT_VERSION})
-  else()
-    set_target_properties(${STATICLIBRARY} PROPERTIES
-      OUTPUT_NAME "cmark-gfm-extensions"
-      VERSION ${PROJECT_VERSION})
-  endif(MSVC)
-
-  list(APPEND CMARK_INSTALL ${STATICLIBRARY})
-endif()
 
 set(CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_NO_WARNINGS ON)
 
@@ -66,12 +41,10 @@ install(TARGETS ${CMARK_INSTALL}
   ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
   )
 
-if (CMARK_SHARED OR CMARK_STATIC)
-  install(FILES
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/cmark-gfm-core-extensions.h
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/module.modulemap
-    DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/cmark_gfm_extensions)
+install(FILES
+  ${CMAKE_CURRENT_SOURCE_DIR}/include/cmark-gfm-core-extensions.h
+  ${CMAKE_CURRENT_SOURCE_DIR}/include/module.modulemap
+  DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/cmark_gfm_extensions)
 
-  install(EXPORT cmark-gfm-extensions
-    DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake-gfm-extensions)
-endif()
+install(EXPORT cmark-gfm-extensions
+  DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake-gfm-extensions)

fuzz/CMakeLists.txt

@@ -1,22 +1,11 @@
-include_directories(
-  ${PROJECT_BINARY_DIR}/extensions
-  ${PROJECT_BINARY_DIR}/src
-  ../extensions
-  ../src
-)
-
-macro(fuzzer name)
-    add_executable(${name} ${name}.c)
-    set_target_properties(${name}
-          PROPERTIES
-          COMPILE_FLAGS "-fsanitize=fuzzer"
-          LINK_FLAGS "-fsanitize=fuzzer")
-    if(CMARK_SHARED)
-      target_link_libraries(${name} libcmark-gfm-extensions libcmark-gfm)
-    elseif(CMARK_STATIC)
-      target_link_libraries(${name} libcmark-gfm-extensions_static libcmark-gfm_static)
-    endif()
-endmacro()
-
-fuzzer(fuzz_quadratic)
-fuzzer(fuzz_quadratic_brackets)
+foreach(fuzzer fuzz_quadratic fuzz_quadratic_brackets)
+  add_executable(${fuzzer}
+    ${fuzzer}.c)
+  target_compile_options(${fuzzer} PRIVATE
+    -fsanitize=fuzzer)
+  target_link_options(${fuzzer} PRIVATE
+    -fsanitize=fuzzer)
+  target_link_libraries(${fuzzer} PRIVATE
+    libcmark-gfm
+    libcmark-gfm-extensions)
+endforeach()