Skip to content

Commit 438f3b2

Browse files
NightFlyerAshe Connor
authored andcommitted
Change cmark_gfm_extensions_get_tasklist_state to cmark_gfm_extensions_tasklist_state_is_checked (commonmark#161)
This is in response to issue commonmark#160. This removes cmark_gfm_extensions_get_tasklist_state and adds the new cmark_gfm_extensions_tasklist_state_is_checked.
1 parent 4b625f5 commit 438f3b2

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

extensions/cmark-gfm-core-extensions.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ extern "C" {
77

88
#include "cmark-gfm-extension_api.h"
99
#include "cmark-gfm-extensions_export.h"
10+
#include "config.h"
1011
#include <stdint.h>
1112

1213
CMARK_GFM_EXTENSIONS_EXPORT
@@ -22,7 +23,7 @@ CMARK_GFM_EXTENSIONS_EXPORT
2223
int cmark_gfm_extensions_get_table_row_is_header(cmark_node *node);
2324

2425
CMARK_GFM_EXTENSIONS_EXPORT
25-
char *cmark_gfm_extensions_get_tasklist_state(cmark_node *node);
26+
bool cmark_gfm_extensions_tasklist_state_is_checked(cmark_node *node);
2627

2728
#ifdef __cplusplus
2829
}

extensions/tasklist.c

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,22 @@ typedef enum {
99
CMARK_TASKLIST_CHECKED,
1010
} cmark_tasklist_type;
1111

12+
// Local constants
13+
static const char *TYPE_STRING = "tasklist";
14+
1215
static const char *get_type_string(cmark_syntax_extension *extension, cmark_node *node) {
13-
return "tasklist";
16+
return TYPE_STRING;
1417
}
1518

16-
char *cmark_gfm_extensions_get_tasklist_state(cmark_node *node) {
17-
if (!node || ((int)node->as.opaque != CMARK_TASKLIST_CHECKED && (int)node->as.opaque != CMARK_TASKLIST_NOCHECKED))
18-
return 0;
19+
bool cmark_gfm_extensions_tasklist_state_is_checked(cmark_node *node) {
20+
if (!node || !node->extension || strcmp(cmark_node_get_type_string(node), TYPE_STRING))
21+
return false;
1922

2023
if ((int)node->as.opaque == CMARK_TASKLIST_CHECKED) {
21-
return "checked";
24+
return true;
2225
}
2326
else {
24-
return "unchecked";
27+
return false;
2528
}
2629
}
2730

0 commit comments

Comments
 (0)