Skip to content

Commit 698c297

Browse files
authored
Merge pull request #2969 from spevans/pr_disable_some_urlsession_tests
TestURLSession: Disable some flaky tests.
2 parents 8f08574 + ce3ccb5 commit 698c297

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Tests/Foundation/Tests/TestURLSession.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1779,7 +1779,7 @@ class TestURLSession: LoopbackServerTest {
17791779
("test_dataTaskWithURLRequest", test_dataTaskWithURLRequest),
17801780
("test_dataTaskWithURLCompletionHandler", test_dataTaskWithURLCompletionHandler),
17811781
("test_dataTaskWithURLRequestCompletionHandler", test_dataTaskWithURLRequestCompletionHandler),
1782-
// ("test_dataTaskWithHttpInputStream", test_dataTaskWithHttpInputStream), - Flaky test
1782+
/* ⚠️ */ ("test_dataTaskWithHttpInputStream", testExpectedToFail(test_dataTaskWithHttpInputStream, "Flaky test")),
17831783
("test_dataTaskWithHTTPBodyRedirect", test_dataTaskWithHTTPBodyRedirect),
17841784
("test_gzippedDataTask", test_gzippedDataTask),
17851785
("test_downloadTaskWithURL", test_downloadTaskWithURL),
@@ -1791,7 +1791,7 @@ class TestURLSession: LoopbackServerTest {
17911791
("test_taskError", test_taskError),
17921792
("test_taskCopy", test_taskCopy),
17931793
("test_cancelTask", test_cancelTask),
1794-
("test_suspendResumeTask", test_suspendResumeTask),
1794+
/* ⚠️ */ ("test_suspendResumeTask", testExpectedToFail(test_suspendResumeTask, "Occasionally breaks")),
17951795
("test_taskTimeout", test_taskTimeout),
17961796
("test_verifyRequestHeaders", test_verifyRequestHeaders),
17971797
("test_verifyHttpAdditionalHeaders", test_verifyHttpAdditionalHeaders),
@@ -1834,7 +1834,7 @@ class TestURLSession: LoopbackServerTest {
18341834
("test_taskCountAfterInvalidateAndCancel", test_taskCountAfterInvalidateAndCancel),
18351835
("test_sessionDelegateAfterInvalidateAndCancel", test_sessionDelegateAfterInvalidateAndCancel),
18361836
/* ⚠️ */ ("test_getAllTasks", testExpectedToFail(test_getAllTasks, "This test causes later ones to crash")),
1837-
("test_getTasksWithCompletion", test_getTasksWithCompletion),
1837+
/* ⚠️ */ ("test_getTasksWithCompletion", testExpectedToFail(test_getTasksWithCompletion, "Flaky tests")),
18381838
/* ⚠️ */ ("test_invalidResumeDataForDownloadTask",
18391839
/* ⚠️ */ testExpectedToFail(test_invalidResumeDataForDownloadTask, "This test crashes nondeterministically: https://bugs.swift.org/browse/SR-11353")),
18401840
/* ⚠️ */ ("test_simpleUploadWithDelegateProvidingInputStream",

0 commit comments

Comments
 (0)