Call uncv close on non-empty slots (#5379)

SiliconA-Z · web-flow · commit 8ebab2669a64 · 2026-01-22T13:55:15.000-08:00
NULL != converter was always true.
diff --git a/Sources/CoreFoundation/CFICUConverters.c b/Sources/CoreFoundation/CFICUConverters.c
@@ -33,7 +33,7 @@ static void __CFICUThreadDataDestructor(void *context) {
         UConverter **limit = converter + data->_numSlots;
         
         while (converter < limit) {
-            if (NULL != converter) ucnv_close(*converter);
+            if (NULL != *converter) ucnv_close(*converter);
             ++converter;
         }
         CFAllocatorDeallocate(NULL, data->_converters);

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ static void __CFICUThreadDataDestructor(void *context) {`
`33`	`33`	`UConverter **limit = converter + data->_numSlots;`
`34`	`34`
`35`	`35`	`while (converter < limit) {`
`36`		`- if (NULL != converter) ucnv_close(*converter);`
	`36`	`+ if (NULL != converter) ucnv_close(converter);`
`37`	`37`	`++converter;`
`38`	`38`	`}`
`39`	`39`	`CFAllocatorDeallocate(NULL, data->_converters);`