Omit Mentioned In section on module pages (#811)

rdar://125512559

Author: bitjammer

src/components/DocumentationTopic.vue

@@ -171,6 +171,7 @@
 
 <script>
 import Language from 'docc-render/constants/Language';
+import SymbolKind from 'docc-render/constants/SymbolKind';
 import metadata from 'theme/mixins/metadata';
 import { buildUrl } from 'docc-render/utils/url-helper';
 import { normalizeRelativePath } from 'docc-render/utils/assets';
@@ -494,7 +495,7 @@ export default {
       ) {
         return false;
       }
-      return symbolKind ? (symbolKind === 'module') : true;
+      return symbolKind ? (symbolKind === SymbolKind.module) : true;
     },
     shortHero: ({
       roleHeading,
@@ -572,8 +573,13 @@ export default {
       topicState.contentWidth > ON_THIS_PAGE_CONTAINER_BREAKPOINT
     ),
     disableMetadata: ({ enableMinimized }) => enableMinimized,
-    primaryContentSectionsSanitized({ primaryContentSections = [] }) {
-      return primaryContentSections.filter(({ kind }) => kind !== SectionKind.declarations);
+    primaryContentSectionsSanitized({ primaryContentSections = [], symbolKind }) {
+      return primaryContentSections.filter(({ kind }) => {
+        if (kind === SectionKind.mentions) {
+          return symbolKind !== SymbolKind.module;
+        }
+        return kind !== SectionKind.declarations;
+      });
     },
     declarations({ primaryContentSections = [] }) {
       return primaryContentSections.filter(({ kind }) => kind === SectionKind.declarations);

src/constants/SymbolKind.js

@@ -17,4 +17,5 @@ export default {
   protocol: 'protocol',
   struct: 'struct',
   uid: 'uid',
+  module: 'module',
 };

tests/unit/components/DocumentationTopic.spec.js

@@ -13,6 +13,7 @@ import DocumentationTopic from 'docc-render/components/DocumentationTopic.vue';
 import Language from 'docc-render/constants/Language';
 import InlinePlusCircleIcon from 'docc-render/components/Icons/InlinePlusCircleIcon.vue';
 import { TopicTypes } from '@/constants/TopicTypes';
+import SymbolKind from '@/constants/SymbolKind';
 import DocumentationHero from '@/components/DocumentationTopic/Hero/DocumentationHero.vue';
 import { TopicSectionsStyle } from '@/constants/TopicSectionsStyle';
 import OnThisPageNav from '@/components/OnThisPageNav.vue';
@@ -368,6 +369,37 @@ describe('DocumentationTopic', () => {
     expect(hierarchy.exists()).toBe(false);
   });
 
+  it('only creates a "Mentioned In" section for non-module pages', () => {
+    const mentionSection = {
+      kind: PrimaryContent.constants.SectionKind.mentions,
+      mentions: [
+        'topic://foo',
+        'topic://bar',
+      ],
+    };
+
+    wrapper.setProps({
+      references: hierarchyItemsReferences,
+      role: TopicTypes.symbol,
+      symbolKind: SymbolKind.protocol,
+      primaryContentSections: [
+        mentionSection,
+        foo,
+      ],
+    });
+
+    expect(wrapper.find(PrimaryContent).props()).toHaveProperty('sections', [
+      mentionSection,
+      foo,
+    ]);
+
+    wrapper.setProps({
+      symbolKind: SymbolKind.module,
+    });
+
+    expect(wrapper.find(PrimaryContent).props()).toHaveProperty('sections', [foo]);
+  });
+
   it('renders `Hierarchy` without its immediate parent if its within overload group', () => {
     wrapper.setProps({
       references: hierarchyItemsReferences,