Remove option to keep input when selecting a new tag (#802) rdar://124954232

Remove option to keep input when selecting a new tag (#802) rdar://124954232

Author: hqhhuang

src/components/Filter/FilterInput.vue

@@ -1,7 +1,7 @@
 <!--
   This source file is part of the Swift.org open source project
 
-  Copyright (c) 2022-2023 Apple Inc. and the Swift project authors
+  Copyright (c) 2022-2024 Apple Inc. and the Swift project authors
   Licensed under Apache License v2.0 with Runtime Library Exception
 
   See https://swift.org/LICENSE.txt for license information
@@ -208,10 +208,6 @@ export default {
       type: Boolean,
       default: false,
     },
-    clearFilterOnTagSelect: {
-      type: Boolean,
-      default: true,
-    },
     preventBorderStyle: {
       type: Boolean,
       default: false,

src/components/Navigator/NavigatorCard.vue

@@ -106,7 +106,6 @@
               :should-keep-open-on-blur="false"
               :shouldTruncateTags="shouldTruncateTags"
               :position-reversed="!renderFilterOnTop"
-              :clear-filter-on-tag-select="false"
               class="filter-component"
               @clear="clearFilters"
             />

src/mixins/multipleSelection.js

@@ -1,7 +1,7 @@
 /**
  * This source file is part of the Swift.org open source project
  *
- * Copyright (c) 2022 Apple Inc. and the Swift project authors
+ * Copyright (c) 2022-2024 Apple Inc. and the Swift project authors
  * Licensed under Apache License v2.0 with Runtime Library Exception
  *
  * See https://swift.org/LICENSE.txt for license information
@@ -55,7 +55,6 @@ export default {
 
     selectTag(tag) {
       this.updateSelectedTags([tag]);
-      if (!this.clearFilterOnTagSelect) return;
       this.setFilterInput('');
     },
 

tests/unit/components/Filter/FilterInput.spec.js

@@ -1,7 +1,7 @@
 /**
  * This source file is part of the Swift.org open source project
  *
- * Copyright (c) 2022-2023 Apple Inc. and the Swift project authors
+ * Copyright (c) 2022-2024 Apple Inc. and the Swift project authors
  * Licensed under Apache License v2.0 with Runtime Library Exception
  *
  * See https://swift.org/LICENSE.txt for license information
@@ -650,16 +650,6 @@ describe('FilterInput', () => {
       expect(wrapper.emitted('input')).toEqual([['']]);
     });
 
-    it('adds tag to `selectedTags` when it is clicked, without clearing the filter', () => {
-      wrapper.setProps({
-        clearFilterOnTagSelect: false,
-      });
-      const selectedTag = 'Tag1';
-      suggestedTags.vm.$emit('click-tags', { tagName: selectedTag });
-      expect(wrapper.emitted('update:selectedTags')).toEqual([[[selectedTag]]]);
-      expect(wrapper.emitted('input')).toBeFalsy();
-    });
-
     describe('when a tag is selected', () => {
       let selectedTagsComponent;
       const selectedTag = 'Tag1';

tests/unit/components/Navigator/NavigatorCard.spec.js

@@ -307,7 +307,6 @@ describe('NavigatorCard', () => {
       ],
       value: '',
       selectInputOnFocus: false,
-      clearFilterOnTagSelect: false,
     });
   });
 

tests/unit/components/Navigator/QuickNavigationModal.spec.js

@@ -1,7 +1,7 @@
 /**
  * This source file is part of the Swift.org open source project
  *
- * Copyright (c) 2022-2023 Apple Inc. and the Swift project authors
+ * Copyright (c) 2022-2024 Apple Inc. and the Swift project authors
  * Licensed under Apache License v2.0 with Runtime Library Exception
  *
  * See https://swift.org/LICENSE.txt for license information
@@ -150,7 +150,6 @@ describe('QuickNavigationModal', () => {
       tags: [],
       translatableTags: [],
       selectInputOnFocus: true,
-      clearFilterOnTagSelect: true,
     });
   });