Remove API that was deprecated during the 6.1 release (#1266)

* Delay removing the deprecated 'diagnostics.json file by 1 minor release

* Keep old deprecated CLI flag for backwards compatibility

* Remove API that was deprecated during the 6.1 release

* Reduce duplication in updated test case

* Simplify providing data to symbol graph loader

* Remove unused API to remove nodes from path hierarchy

Author: d-ronnqvist

Sources/SwiftDocC/DocumentationService/Convert/ConvertService.swift

@@ -243,7 +243,8 @@ public struct ConvertService: DocumentationService {
             .compactMap { (value, isDocumentationExtensionContent) -> (ResolvedTopicReference, RenderReferenceStore.TopicContent)? in
                 let (topicReference, article) = value
 
-                guard let bundle = context.bundle, bundle.id == topicReference.bundleID else { return nil }
+                let bundle = context.bundle
+                guard bundle.id == topicReference.bundleID else { return nil }
                 let renderer = DocumentationContentRenderer(documentationContext: context, bundle: bundle)
 
                 let documentationNodeKind: DocumentationNode.Kind = isDocumentationExtensionContent ? .unknownSymbol : .article
@@ -293,3 +294,11 @@ private extension SymbolGraph.LineList.Line {
         )
     }
 }
+
+private extension DocumentationNode {
+    func meetsExpandedDocumentationRequirements(_ requirements: ConvertRequest.ExpandedDocumentationRequirements) -> Bool {
+        guard let symbol else { return false }
+        
+        return requirements.accessControlLevels.contains(symbol.accessLevel.rawValue) && (!symbol.names.title.starts(with: "_") || requirements.canBeUnderscored)
+    }
+}