Mark automatic curation topic sections as "generated" in Render JSON (#749)

rdar://116584446

Author: d-ronnqvist

Sources/SwiftDocC/Model/Rendering/RenderNodeTranslator.swift

@@ -795,13 +795,7 @@ public struct RenderNodeTranslator: SemanticVisitor {
                 renderer: contentRenderer
             ) {
                 contentCompiler.collectedTopicReferences.append(contentsOf: seeAlso.references)
-                seeAlsoSections.append(TaskGroupRenderSection(
-                    title: seeAlso.title,
-                    abstract: nil,
-                    discussion: nil,
-                    identifiers: seeAlso.references.map { $0.absoluteString },
-                    generated: true
-                ))
+                seeAlsoSections.append(TaskGroupRenderSection(taskGroup: seeAlso))
             }
 
             return seeAlsoSections
@@ -1531,12 +1525,7 @@ public struct RenderNodeTranslator: SemanticVisitor {
                 guard !newReferences.isEmpty else { return nil }
 
                 contentCompiler.collectedTopicReferences.append(contentsOf: newReferences)
-                return TaskGroupRenderSection(
-                    title: group.title,
-                    abstract: nil,
-                    discussion: nil,
-                    identifiers: newReferences.map { $0.absoluteString }
-                )
+                return TaskGroupRenderSection(taskGroup: (title: group.title, references: newReferences))
             })
 
             // Place "bottom" rendering preference automatic task groups
@@ -1628,13 +1617,7 @@ public struct RenderNodeTranslator: SemanticVisitor {
             ), !seeAlso.references.isEmpty {
                 contentCompiler.collectedTopicReferences.append(contentsOf: seeAlso.references)
                 seeAlsoSections.append(
-                    TaskGroupRenderSection(
-                        title: seeAlso.title,
-                        abstract: nil,
-                        discussion: nil,
-                        identifiers: seeAlso.references.map { $0.absoluteString },
-                        generated: true
-                    )
+                    TaskGroupRenderSection(taskGroup: seeAlso)
                 )
             }
 

Sources/SwiftDocC/Model/Rendering/Symbol/TaskGroupRenderSection.swift

@@ -90,7 +90,7 @@ extension TaskGroupRenderSection {
         self.title = group.title
         self.abstract = nil
         self.identifiers = group.references.map({ $0.absoluteString })
-        self.generated = false
+        self.generated = true
         self.discussion = nil
     }
 }

Tests/SwiftDocCTests/Infrastructure/AutomaticCurationTests.swift

@@ -41,6 +41,10 @@ class AutomaticCurationTests: XCTestCase {
             var translator = RenderNodeTranslator(context: context, bundle: bundle, identifier: node.reference, source: nil)
             let renderNode = translator.visit(symbol) as! RenderNode
 
+            for section in renderNode.topicSections {
+                XCTAssert(section.generated, "\((section.title ?? "").singleQuoted) was not marked as generated.")
+            }
+            
             XCTAssertNotNil(renderNode.topicSections.first(where: { group -> Bool in
                 return group.title == AutomaticCuration.groupTitle(for: kind)
             }), "\(kind.identifier) was not automatically curated in a \(AutomaticCuration.groupTitle(for: kind).singleQuoted) topic group. Please add it to either AutomaticCuration.groupKindOrder or KindIdentifier.noPageKinds." )
@@ -124,6 +128,13 @@ class AutomaticCurationTests: XCTestCase {
             // The manual topic section is listed before any automatic topic sections
             XCTAssertEqual(renderNode.topicSections.first?.title, "Manually curated")
 
+            if let firstSection = renderNode.topicSections.first {
+                XCTAssertFalse(firstSection.generated, "The first topic section is manually authored.")
+            }
+            for section in renderNode.topicSections.dropFirst() {
+                XCTAssert(section.generated, "The other topic sections are generated")
+            }
+            
             // Check that the automatic topic sections only exist if its elements weren't manually curated
             XCTAssertEqual(
                 !curatedIndices.contains(0),