Relax rules for decoding JSON for asides with custom styles (#829)

* RenderBlockContent#init(from decoder:) overwrites aside style with
name (if present) for all aside styles not just for notes.

* Update Tests/SwiftDocCTests/Model/SemaToRenderNodeTests.swift

Co-authored-by: David Rönnqvist <[email protected]>

Author: patshaughnessy

Sources/SwiftDocC/Model/Rendering/Content/RenderBlockContent.swift

@@ -711,7 +711,7 @@ extension RenderBlockContent: Codable {
             self = try .paragraph(.init(inlineContent: container.decode([RenderInlineContent].self, forKey: .inlineContent)))
         case .aside:
             var style = try container.decode(AsideStyle.self, forKey: .style)
-            if style.renderKind == "note", let displayName = try container.decodeIfPresent(String.self, forKey: .name) {
+            if let displayName = try container.decodeIfPresent(String.self, forKey: .name) {
                 style = AsideStyle(displayName: displayName)
             }
             self = try .aside(.init(style: style, content: container.decode([RenderBlockContent].self, forKey: .content)))

Tests/SwiftDocCTests/Model/SemaToRenderNodeTests.swift

@@ -2956,9 +2956,41 @@ Document
             {"type":"aside", "style":"note", "name":"See Also",
                 "content": [{"type":"paragraph", "inlineContent":[{"type":"text", "text":"And this other thing."}]}]},
             {"type":"aside", "style":"note", "name":"Throws",
-                "content": [{"type":"paragraph", "inlineContent":[{"type":"text", "text":"A serious error."}]}]}
+                "content": [{"type":"paragraph", "inlineContent":[{"type":"text", "text":"A serious error."}]}]},
             ]
             """)
+
+        // While decoding, overwrite the style with the name, if both are specified. We expect the style's raw value
+        // to be "Custom Title", not "important" in this example.
+        try assertJSONRepresentation(
+            RenderBlockContent.aside(
+                .init(
+                    style: .init(rawValue: "Custom Title"),
+                    content: [.paragraph(.init(inlineContent: [.text("This is a custom title...")]))]
+                )
+            ),
+            """
+            {
+              "type": "aside",
+              "content": [
+                {
+                  "type": "paragraph",
+                  "inlineContent": [
+                    {
+                      "type": "text",
+                      "text": "This is a custom title..."
+                    }
+                  ]
+                }
+              ],
+              "style": "important",
+              "name": "Custom Title"
+            }
+            """)
+            
+        for style in Aside.Kind.allCases.map({ RenderBlockContent.AsideStyle(asideKind: $0) }) + [.init(displayName: "Custom Title")] {
+            try assertRoundTripCoding(RenderBlockContent.aside(.init(style: style, content: [.paragraph(.init(inlineContent: [.text("This is a custom title...")]))])))
+        }
     }
 
     /// Tests links to symbols that have deprecation summary in markdown appear deprecated.