Skip to content

Commit 0d4f5ab

Browse files
authored
Merge pull request #260 from gwynne/minor-readme-updates
Minor README fixes and whitespace normalization
2 parents 2d2c2fb + 8b2da84 commit 0d4f5ab

File tree

4 files changed

+13
-14
lines changed

4 files changed

+13
-14
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@ docker run -it swift /bin/bash
2424
If you want to run the Swift REPL you will need to run the container with additional privileges:
2525

2626
```bash
27+
# If running Docker on Linux:
2728
docker run --security-opt seccomp=unconfined -it swift
29+
30+
# If running Docker on macOS:
31+
docker run --privileged -it swift
2832
```
2933

3034
We also provide a "slim" image. Slim images are images designed just for running an already built Swift program. Consequently, they do not contain the Swift compiler.
@@ -40,7 +44,7 @@ RUN swift build -c release
4044
FROM swift:slim
4145
WORKDIR /root
4246
COPY --from=builder /root .
43-
CMD [".build/x86_64-unknown-linux/release/docker-test"]
47+
CMD [".build/release/docker-test"]
4448
```
4549

4650
## Contributions

swift-ci/README.md

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,17 @@
22

33
Swift.org uses Docker based virtual build environment to build & qualify Swift toolchains on Linux.
44

5-
The Continuous Integration system uses the Dockerfiles in this directory to define the virtual build environment,
6-
then runs the build and qualification steps inside a docker container based on the image.
5+
The Continuous Integration system uses the Dockerfiles in this directory to define the virtual build environment, then runs the build and qualification steps inside a docker container based on the image.
76

87
## Directory Structure
98

10-
The Dockerfiles used for Continuous Integration are layed out under the top level `swift-ci` directory.
11-
Under that, we have a directory for each of the target branches, e.g.
12-
Continuous Integration for Swift's `master` branch uses the `swift-ci/master` Dockerfiles.
9+
The Dockerfiles used for Continuous Integration are layed out under the top level `swift-ci` directory. Under that, we have a directory for each of the target branches, e.g. Continuous Integration for Swift's `main` branch uses the `swift-ci/master` Dockerfiles.
1310

1411
There is also a specific directory (`swift-docc-render`) for the Dockerfile used to build Swift-DocC-Render. Swift-DocC-Render builds separately from the rest of the projects in the Swift toolchain and ships a pre-built copy for use in the toolchain in the Swift-DocC-Render-Artifact repository.
1512

1613
## Continuous Integration
1714

18-
This system is designed to support many distributions.
19-
Once a working Dockerfile is added to this repository,
20-
we set up Continuous Integration jobs to produce toolchains for the distribution and publish them on Swift.org.
15+
This system is designed to support many distributions. Once a working Dockerfile is added to this repository, we set up Continuous Integration jobs to produce toolchains for the distribution and publish them on Swift.org.
2116

2217
## Local development & testing
2318

@@ -27,7 +22,7 @@ First build & tag the Dockerfile:
2722
docker build -f <dockerfile path> . -t <some tag>
2823
```
2924

30-
Next run the Swift build using that Docker image
25+
Next, run the Swift build using that Docker image:
3126

3227
```bash
3328
docker run \
@@ -37,7 +32,7 @@ docker run \
3732
-v <some docker volume name>:/home/build-user \
3833
-w /home/build-user/ \
3934
<docker image tag from above> \
40-
/bin/bash -lc "cp -r /source/* /home/build-user/; ./swift/utils/build-script --preset buildbot_linux"
35+
/bin/bash -lc "cp -r /source/* /home/build-user/; ./swift/utils/build-script --preset buildbot_linux install_destdir=/home/build-user/swift-install installable_package=/home/build-user/swift-DEVELOPMENT-SNAPSHOT-$(date +'%F')-a.tar.gz"
4136
```
4237

4338
## Contributions

swift-ci/master/debian/10/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ RUN apt-get -y update && apt-get -y --no-install-recommends install \
3030
systemtap-sdt-dev \
3131
tzdata \
3232
unzip \
33-
uuid-dev \
33+
uuid-dev \
3434
ca-certificates
3535

3636
USER build-user

swift-ci/master/debian/9/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ RUN apt-get --no-install-recommends -y install \
2828
systemtap-sdt-dev \
2929
tzdata \
3030
unzip \
31-
ca-certificates \
31+
ca-certificates \
3232
uuid-dev
3333

3434
USER build-user
3535

36-
WORKDIR /home/build-user
36+
WORKDIR /home/build-user

0 commit comments

Comments
 (0)