Skip to content

Commit cb26e2f

Browse files
shahmishalshahmishal
authored
Update Windows Dockerfile to exit on verification of vs_buildtools.exe (#491)
* Update Windows Dockerfile to exit on verification of vs_buildtools.exe * Update the SHA for vs_buildtools to 95B8BCAC49757DBA2BD80827484E65B2F0EF57C11C143B87514B913839F78657 * Fix the exit 1 issue with vs_buildtools.exe * Update the vs_BuildTools.exe version/SHA
1 parent 3bf68fb commit cb26e2f

File tree

16 files changed

+34
-18
lines changed

16 files changed

+34
-18
lines changed

‎5.10/windows/1809/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
100100
Write-Host '✓'; \
101101
} else { \
102102
Write-Host ('✘ ({0})' -f $Hash.Hash); \
103+
exit 1; \
103104
} \
104105
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
105106
$Process = \

‎5.10/windows/LTSC2022/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
100100
Write-Host '✓'; \
101101
} else { \
102102
Write-Host ('✘ ({0})' -f $Hash.Hash); \
103+
exit 1; \
103104
} \
104105
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
105106
$Process = \

‎5.9/windows/LTSC2022/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
100100
Write-Host '✓'; \
101101
} else { \
102102
Write-Host ('✘ ({0})' -f $Hash.Hash); \
103+
exit 1; \
103104
} \
104105
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
105106
$Process = \

‎6.0/windows/1809/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
100100
Write-Host '✓'; \
101101
} else { \
102102
Write-Host ('✘ ({0})' -f $Hash.Hash); \
103+
exit 1; \
103104
} \
104105
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
105106
$Process = \

‎6.0/windows/LTSC2022/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
100100
Write-Host '✓'; \
101101
} else { \
102102
Write-Host ('✘ ({0})' -f $Hash.Hash); \
103+
exit 1; \
103104
} \
104105
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
105106
$Process = \

‎6.1/windows/1809/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
100100
Write-Host '✓'; \
101101
} else { \
102102
Write-Host ('✘ ({0})' -f $Hash.Hash); \
103+
exit 1; \
103104
} \
104105
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
105106
$Process = \

‎6.1/windows/LTSC2022/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
100100
Write-Host '✓'; \
101101
} else { \
102102
Write-Host ('✘ ({0})' -f $Hash.Hash); \
103+
exit 1; \
103104
} \
104105
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
105106
$Process = \

‎nightly-6.0/windows/1809/Dockerfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
9595
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9696

9797
# Install Visual Studio Build Tools
98-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
99-
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
98+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
99+
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
100100
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
101101
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
102102
Write-Host '✓'; \
@@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
106106
Write-Host '✓'; \
107107
} else { \
108108
Write-Host ('✘ ({0})' -f $Hash.Hash); \
109+
exit 1; \
109110
} \
110111
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
111112
$Process = \

‎nightly-6.0/windows/LTSC2022/Dockerfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
9595
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9696

9797
# Install Visual Studio Build Tools
98-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
99-
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
98+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
99+
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
100100
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
101101
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
102102
Write-Host '✓'; \
@@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
106106
Write-Host '✓'; \
107107
} else { \
108108
Write-Host ('✘ ({0})' -f $Hash.Hash); \
109+
exit 1; \
109110
} \
110111
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
111112
$Process = \

‎nightly-6.1/windows/1809/Dockerfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
9595
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9696

9797
# Install Visual Studio Build Tools
98-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
99-
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
98+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
99+
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
100100
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
101101
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
102102
Write-Host '✓'; \
@@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
106106
Write-Host '✓'; \
107107
} else { \
108108
Write-Host ('✘ ({0})' -f $Hash.Hash); \
109+
exit 1; \
109110
} \
110111
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
111112
$Process = \

0 commit comments

Comments
 (0)