Skip to content

Commit e621815

Browse files
committed
Tests: clean up XCTAssertTrue usage for negated equality
1 parent 230f874 commit e621815

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

Tests/SwiftDriverTests/ExplicitModuleBuildTests.swift

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ final class ExplicitModuleBuildTests: XCTestCase {
475475
case .swift("testExplicitLinkLibraries"):
476476
let linkLibraries = try XCTUnwrap(depInfo.linkLibraries)
477477
if driver.targetTriple.isDarwin {
478-
XCTAssertTrue(!linkLibraries.isEmpty)
478+
XCTAssertFalse(linkLibraries.isEmpty)
479479
XCTAssertTrue(linkLibraries.contains { $0.linkName == "objc" })
480480
}
481481
default:
@@ -2400,8 +2400,8 @@ final class ExplicitModuleBuildTests: XCTestCase {
24002400
XCTAssertEqual(getInputModules(HJobs[1]), ["A", "E", "F", "G", "Swift"])
24012401
// x86_64
24022402
XCTAssertEqual(getInputModules(HJobs[2]), ["A", "E", "F", "G", "Swift"])
2403-
XCTAssertTrue(getOutputName(HJobs[0]) != getOutputName(HJobs[1]))
2404-
XCTAssertTrue(getOutputName(HJobs[1]) != getOutputName(HJobs[2]))
2403+
XCTAssertNotEqual(getOutputName(HJobs[0]), getOutputName(HJobs[1]))
2404+
XCTAssertNotEqual(getOutputName(HJobs[1]), getOutputName(HJobs[2]))
24052405
checkInputOutputIntegrity(HJobs[0])
24062406
checkInputOutputIntegrity(HJobs[1])
24072407
checkInputOutputIntegrity(HJobs[2])
@@ -2410,8 +2410,8 @@ final class ExplicitModuleBuildTests: XCTestCase {
24102410
XCTAssertEqual(getInputModules(GJobs[0]), ["E", "E", "Swift", "Swift"])
24112411
XCTAssertEqual(getInputModules(GJobs[1]), ["E", "Swift"])
24122412
XCTAssertEqual(getInputModules(GJobs[2]), ["E", "Swift"])
2413-
XCTAssertTrue(getOutputName(GJobs[0]) != getOutputName(GJobs[1]))
2414-
XCTAssertTrue(getOutputName(GJobs[1]) != getOutputName(GJobs[2]))
2413+
XCTAssertNotEqual(getOutputName(GJobs[0]), getOutputName(GJobs[1]))
2414+
XCTAssertNotEqual(getOutputName(GJobs[1]), getOutputName(GJobs[2]))
24152415
checkInputOutputIntegrity(GJobs[0])
24162416
checkInputOutputIntegrity(GJobs[1])
24172417
}
@@ -2439,7 +2439,7 @@ final class ExplicitModuleBuildTests: XCTestCase {
24392439
XCTAssertEqual(getInputModules(HJobs[1]), ["A", "E", "F", "G", "Swift"])
24402440
// x86_64
24412441
XCTAssertEqual(getInputModules(HJobs[2]), ["A", "E", "F", "G", "Swift"])
2442-
XCTAssertTrue(getOutputName(HJobs[0]) != getOutputName(HJobs[1]))
2442+
XCTAssertNotEqual(getOutputName(HJobs[0]), getOutputName(HJobs[1]))
24432443
checkInputOutputIntegrity(HJobs[0])
24442444
checkInputOutputIntegrity(HJobs[1])
24452445

@@ -2448,8 +2448,8 @@ final class ExplicitModuleBuildTests: XCTestCase {
24482448
XCTAssertEqual(getInputModules(GJobs[0]), ["E", "E", "Swift", "Swift"])
24492449
XCTAssertEqual(getInputModules(GJobs[1]), ["E", "Swift"])
24502450
XCTAssertEqual(getInputModules(GJobs[2]), ["E", "Swift"])
2451-
XCTAssertTrue(getOutputName(GJobs[0]) != getOutputName(GJobs[1]))
2452-
XCTAssertTrue(getOutputName(GJobs[1]) != getOutputName(GJobs[2]))
2451+
XCTAssertNotEqual(getOutputName(GJobs[0]), getOutputName(GJobs[1]))
2452+
XCTAssertNotEqual(getOutputName(GJobs[1]), getOutputName(GJobs[2]))
24532453
checkInputOutputIntegrity(GJobs[0])
24542454
checkInputOutputIntegrity(GJobs[1])
24552455
}
@@ -2514,7 +2514,7 @@ final class ExplicitModuleBuildTests: XCTestCase {
25142514
let (baseline, current) = (job.inputs[0], job.inputs[1])
25152515
XCTAssertEqual(baseline.type, .jsonABIBaseline)
25162516
XCTAssertEqual(current.type, .jsonABIBaseline)
2517-
XCTAssertTrue(current.file != baseline.file)
2517+
XCTAssertNotEqual(current.file, baseline.file)
25182518
XCTAssertEqual(current.file.basename, baseline.file.basename)
25192519
}
25202520
let mockSDKPath: String =

0 commit comments

Comments
 (0)