Skip to content

Commit f0264f0

Browse files
committed
Remove extra checks for no emitted diagnostics in 'testPrintingExplicitDependencyGraph'
These do not actually have much to do with the test. If dependency scanner produces an error or a warning, for example, all this test needs to make sure the right data is emitted to the output. Other tests verify the actual integrity of the scanning action's output. Resolves rdar://99977956
1 parent 6c71f58 commit f0264f0

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

Tests/SwiftDriverTests/ExplicitModuleBuildTests.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1294,7 +1294,6 @@ final class ExplicitModuleBuildTests: XCTestCase {
12941294
"-explicit-dependency-graph-format=json"],
12951295
diagnosticsEngine: diagnosticEngine)
12961296
let _ = try driver.planBuild()
1297-
XCTAssertFalse(diagnosticEngine.hasErrors)
12981297
}
12991298

13001299
let output = try withHijackedOutputStream {
@@ -1304,7 +1303,6 @@ final class ExplicitModuleBuildTests: XCTestCase {
13041303
"-explicit-dependency-graph-format=json"],
13051304
diagnosticsEngine: diagnosticEngine)
13061305
let _ = try driver.planBuild()
1307-
XCTAssertFalse(diagnosticEngine.hasErrors)
13081306
}
13091307
XCTAssertTrue(output.contains("\"mainModuleName\" : \"testPrintingExplicitDependencyGraph\","))
13101308

@@ -1315,7 +1313,6 @@ final class ExplicitModuleBuildTests: XCTestCase {
13151313
"-explicit-dependency-graph-format=dot"],
13161314
diagnosticsEngine: diagnosticEngine)
13171315
let _ = try driver.planBuild()
1318-
XCTAssertFalse(diagnosticEngine.hasErrors)
13191316
}
13201317
XCTAssertTrue(output2.contains("\"testPrintingExplicitDependencyGraph\" [shape=box, style=bold, color=navy"))
13211318

@@ -1325,7 +1322,6 @@ final class ExplicitModuleBuildTests: XCTestCase {
13251322
"-print-explicit-dependency-graph"],
13261323
diagnosticsEngine: diagnosticEngine)
13271324
let _ = try driver.planBuild()
1328-
XCTAssertFalse(diagnosticEngine.hasErrors)
13291325
}
13301326
XCTAssertTrue(output3.contains("\"mainModuleName\" : \"testPrintingExplicitDependencyGraph\","))
13311327
}

0 commit comments

Comments
 (0)