Skip to content

Commit 36e135e

Browse files
authored
Merge pull request #2913 from suzannaratcliff/suzannaratcliff/issue-severity-proposal-updates
Updates to the issue severity proposal: 0013
2 parents 07e7020 + fa24155 commit 36e135e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

proposals/testing/0013-issue-severity-warning.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ Issue.record("My comment", severity: .warning)
7777
Here is the `Issue.record` method definition with severity as a parameter.
7878

7979
```swift
80-
/// Record an issue when a running test fails unexpectedly.
80+
/// Record an issue when a running test and an issue occurs.
8181
///
8282
/// - Parameters:
8383
/// - comment: A comment describing the expectation.
84-
/// - severity: The severity of the issue.
84+
/// - severity: The severity level of the issue. This factor impacts whether the issue constitutes a failure.
8585
/// - sourceLocation: The source location to which the issue should be
8686
/// attributed.
8787
///
@@ -117,7 +117,7 @@ public var severity: Severity { get set }
117117

118118
```
119119

120-
- `isFailure`: A boolean property to determine if an issue results in a test failure, thereby helping in result aggregation and reporting.
120+
- `isFailure`: A boolean computed property to determine if an issue results in a test failure, thereby helping in result aggregation and reporting.
121121

122122
```swift
123123
extension Issue {
@@ -154,7 +154,7 @@ This revision aims to clarify the functionality and usage of the `Severity` enum
154154

155155
### Integration with supporting tools
156156

157-
Issue severity will be in the event stream output when a `issueRecorded` event occurs. This will be a breaking change because some tools may assume that all `issueRecorded` events are failing. Due to this we will be bumping the event stream version and v1 will maintain it's behavior and not output any events for non failing issues. We will also be adding `isFailure` to the issue so that clients will know if the issue should be treated as a failure.
157+
Issue severity will be in the event stream output when a `issueRecorded` event occurs. This will be a breaking change because some tools may assume that all `issueRecorded` events are failing. Due to this we will be bumping the event stream version and v1 will maintain it's behavior and not output any events for non failing issues. We will also be adding `isFailure` to the issue so that clients will know if the issue should be treated as a failure. `isFailure` is a computed property.
158158

159159
The JSON event stream ABI will be amended correspondingly:
160160

0 commit comments

Comments
 (0)