Skip to content

Commit 5d03375

Browse files
authored
Consistently format the 'Review:' header field of all Swift Testing proposals (#2837)
1 parent 042e168 commit 5d03375

10 files changed

+10
-15
lines changed

proposals/testing/0001-refactor-bug-inits.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* Authors: [Jonathan Grynspan](https://github.com/grynspan)
55
* Status: **Implemented (Swift 6.0)**
66
* Implementation: [swiftlang/swift-testing#401](https://github.com/swiftlang/swift-testing/pull/401)
7-
* Review: ([pitch](https://forums.swift.org/t/pitch-dedicated-bug-functions-for-urls-and-ids/71842)), ([acceptance](https://forums.swift.org/t/swt-0001-dedicated-bug-functions-for-urls-and-ids/71842/2))
7+
* Review: ([pitch](https://forums.swift.org/t/pitch-dedicated-bug-functions-for-urls-and-ids/71842)) ([acceptance](https://forums.swift.org/t/swt-0001-dedicated-bug-functions-for-urls-and-ids/71842/2))
88

99
> [!NOTE]
1010
> This proposal was accepted before Swift Testing began using the Swift

proposals/testing/0002-json-abi.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* Status: **Implemented (Swift 6.0)**
66
* Implementation: [swiftlang/swift-testing#383](https://github.com/swiftlang/swift-testing/pull/383),
77
[swiftlang/swift-testing#402](https://github.com/swiftlang/swift-testing/pull/402)
8-
* Review: ([pitch](https://forums.swift.org/t/pitch-a-stable-json-based-abi-for-tools-integration/72627)), ([acceptance](https://forums.swift.org/t/pitch-a-stable-json-based-abi-for-tools-integration/72627/4))
8+
* Review: ([pitch](https://forums.swift.org/t/pitch-a-stable-json-based-abi-for-tools-integration/72627)) ([acceptance](https://forums.swift.org/t/pitch-a-stable-json-based-abi-for-tools-integration/72627/4))
99

1010
> [!NOTE]
1111
> This proposal was accepted before Swift Testing began using the Swift

proposals/testing/0003-make-serialized-trait-api.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@
55
* Status: **Implemented (Swift 6.0)**
66
* Implementation:
77
[swiftlang/swift-testing#535](https://github.com/swiftlang/swift-testing/pull/535)
8-
* Review:
9-
([pitch](https://forums.swift.org/t/pitch-make-serialized-trait-public-api/73147)),
10-
([acceptance](https://forums.swift.org/t/pitch-make-serialized-trait-public-api/73147/5))
8+
* Review: ([pitch](https://forums.swift.org/t/pitch-make-serialized-trait-public-api/73147)) ([acceptance](https://forums.swift.org/t/pitch-make-serialized-trait-public-api/73147/5))
119

1210
> [!NOTE]
1311
> This proposal was accepted before Swift Testing began using the Swift

proposals/testing/0004-constrain-the-granularity-of-test-time-limit-durations.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@
55
* Status: **Implemented (Swift 6.0)**
66
* Implementation:
77
[swiftlang/swift-testing#534](https://github.com/swiftlang/swift-testing/pull/534)
8-
* Review:
9-
([pitch](https://forums.swift.org/t/pitch-constrain-the-granularity-of-test-time-limit-durations/73146)),
10-
([acceptance](https://forums.swift.org/t/pitch-constrain-the-granularity-of-test-time-limit-durations/73146/3))
8+
* Review: ([pitch](https://forums.swift.org/t/pitch-constrain-the-granularity-of-test-time-limit-durations/73146)) ([acceptance](https://forums.swift.org/t/pitch-constrain-the-granularity-of-test-time-limit-durations/73146/3))
119

1210
> [!NOTE]
1311
> This proposal was accepted before Swift Testing began using the Swift

proposals/testing/0005-ranged-confirmations.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
* Status: **Implemented (Swift 6.1)**
66
* Bug: rdar://138499457
77
* Implementation: [swiftlang/swift-testing#598](https://github.com/swiftlang/swift-testing/pull/598), [swiftlang/swift-testing#689](https://github.com/swiftlang/swift-testing/pull689)
8-
* Review: ([pitch](https://forums.swift.org/t/pitch-range-based-confirmations/74589)),
9-
([acceptance](https://forums.swift.org/t/pitch-range-based-confirmations/74589/7))
8+
* Review: ([pitch](https://forums.swift.org/t/pitch-range-based-confirmations/74589)) ([acceptance](https://forums.swift.org/t/pitch-range-based-confirmations/74589/7))
109

1110
> [!NOTE]
1211
> This proposal was accepted before Swift Testing began using the Swift

proposals/testing/0006-return-errors-from-expect-throws.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* Status: **Implemented (Swift 6.1)**
66
* Bug: rdar://138235250
77
* Implementation: [swiftlang/swift-testing#780](https://github.com/swiftlang/swift-testing/pull/780)
8-
* Review: ([pitch](https://forums.swift.org/t/pitch-returning-errors-from-expect-throws/75567)), ([acceptance](https://forums.swift.org/t/pitch-returning-errors-from-expect-throws/75567/5))
8+
* Review: ([pitch](https://forums.swift.org/t/pitch-returning-errors-from-expect-throws/75567)) ([acceptance](https://forums.swift.org/t/pitch-returning-errors-from-expect-throws/75567/5))
99

1010
> [!NOTE]
1111
> This proposal was accepted before Swift Testing began using the Swift

proposals/testing/0007-test-scoping-traits.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* Authors: [Stuart Montgomery](https://github.com/stmontgomery)
55
* Status: **Implemented (Swift 6.1)**
66
* Implementation: [swiftlang/swift-testing#733](https://github.com/swiftlang/swift-testing/pull/733), [swiftlang/swift-testing#86](https://github.com/swiftlang/swift-testing/pull/86)
7-
* Review: ([pitch](https://forums.swift.org/t/pitch-custom-test-execution-traits/75055)), ([review](https://forums.swift.org/t/proposal-test-scoping-traits/76676)), ([acceptance](https://forums.swift.org/t/proposal-test-scoping-traits/76676/3))
7+
* Review: ([pitch](https://forums.swift.org/t/pitch-custom-test-execution-traits/75055)) ([review](https://forums.swift.org/t/proposal-test-scoping-traits/76676)) ([acceptance](https://forums.swift.org/t/proposal-test-scoping-traits/76676/3))
88

99
> [!NOTE]
1010
> This proposal was accepted before Swift Testing began using the Swift

proposals/testing/0008-exit-tests.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Bug: [apple/swift-testing#157](https://github.com/apple/swift-testing/issues/157)
88
* Implementation: [apple/swift-testing#324](https://github.com/swiftlang/swift-testing/pull/324)
99
* Previous Revision: [1](https://github.com/swiftlang/swift-evolution/blob/fdfc7867df4e35e29b2a24edee34ea4412ec15b0/proposals/testing/0008-exit-tests.md)
10-
* Review: ([acceptance](https://forums.swift.org/t/accepted-with-modifications-st-0008-exit-tests/79553)) ([second review](https://forums.swift.org/t/second-review-st-0008-exit-tests/79198)), ([review](https://forums.swift.org/t/st-0008-exit-tests/78692)), ([pitch](https://forums.swift.org/t/pitch-exit-tests/78071))
10+
* Review: ([pitch](https://forums.swift.org/t/pitch-exit-tests/78071)) ([review](https://forums.swift.org/t/st-0008-exit-tests/78692)) ([second review](https://forums.swift.org/t/second-review-st-0008-exit-tests/79198)) ([acceptance](https://forums.swift.org/t/accepted-with-modifications-st-0008-exit-tests/79553))
1111

1212
## Introduction
1313

proposals/testing/0009-attachments.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* Status: **Implemented (Swift 6.2)**
77
* Bug: [swiftlang/swift-testing#714](https://github.com/swiftlang/swift-testing/issues/714)
88
* Implementation: [swiftlang/swift-testing#973](https://github.com/swiftlang/swift-testing/pull/973)
9-
* Review: ([acceptance](https://forums.swift.org/t/accepted-with-modifications-st-0009-attachments/79193)), ([review](https://forums.swift.org/t/st-0009-attachments/78698)), ([pitch](https://forums.swift.org/t/pitch-attachments/78072))
9+
* Review: ([pitch](https://forums.swift.org/t/pitch-attachments/78072)) ([review](https://forums.swift.org/t/st-0009-attachments/78698)) ([acceptance](https://forums.swift.org/t/accepted-with-modifications-st-0009-attachments/79193))
1010

1111
## Introduction
1212

proposals/testing/0010-evaluate-condition.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* Status: **Implemented (Swift 6.2)**
77
* Bug: [swiftlang/swift-testing#903](https://github.com/swiftlang/swift-testing/issues/903)
88
* Implementation: [swiftlang/swift-testing#909](https://github.com/swiftlang/swift-testing/pull/909), [swiftlang/swift-testing#1097](https://github.com/swiftlang/swift-testing/pull/1097)
9-
* Review: ([pitch](https://forums.swift.org/t/pitch-introduce-conditiontrait-evaluate/77242)), ([review](https://forums.swift.org/t/st-0010-public-api-to-evaluate-conditiontrait/79232)), ([acceptance](https://forums.swift.org/t/accepted-st-0010-public-api-to-evaluate-conditiontrait/79577))
9+
* Review: ([pitch](https://forums.swift.org/t/pitch-introduce-conditiontrait-evaluate/77242)) ([review](https://forums.swift.org/t/st-0010-public-api-to-evaluate-conditiontrait/79232)) ([acceptance](https://forums.swift.org/t/accepted-st-0010-public-api-to-evaluate-conditiontrait/79577))
1010

1111
## Introduction
1212

0 commit comments

Comments
 (0)