Skip to content

Commit 5ff0900

Browse files
committed
Adjustments to ST-0009.
This PR makes some further adjustments to ST-0009 to ensure the rename from `AttachableContainer` to `AttachableWrapper` is also applied to its associated type (i.e. `AttachableValue` -> `Wrapped`) and corresponding property (i.e. `attachableValue` -> `wrappedValue`).
1 parent cc52603 commit 5ff0900

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

proposals/testing/0009-attachments.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Proposal: [ST-0009](0009-attachments.md)
44
* Authors: [Jonathan Grynspan](https://github.com/grynspan)
55
* Review Manager: [Rachel Brindle](https://github.com/younata)
6-
* Status: **Accepted**
6+
* Status: **Accepted with revisions**
77
* Bug: [swiftlang/swift-testing#714](https://github.com/swiftlang/swift-testing/issues/714)
88
* Implementation: [swiftlang/swift-testing#973](https://github.com/swiftlang/swift-testing/pull/973)
99
* Review: ([acceptance](https://forums.swift.org/t/accepted-with-modifications-st-0009-attachments/79193)), ([review](https://forums.swift.org/t/st-0009-attachments/78698)), ([pitch](https://forums.swift.org/t/pitch-attachments/78072))
@@ -259,12 +259,12 @@ that refines `Attachable`:
259259
/// A type can conform to this protocol if it represents another type that
260260
/// cannot directly conform to ``Attachable``, such as a non-final class or a
261261
/// type declared in a third-party module.
262-
public protocol AttachableWrapper<AttachableValue>: Attachable, ~Copyable {
263-
/// The type of the attachable value represented by this type.
264-
associatedtype AttachableValue
262+
public protocol AttachableWrapper<Wrapped>: Attachable, ~Copyable {
263+
/// The type of the underlying value represented by this type.
264+
associatedtype Wrapped
265265

266-
/// The attachable value represented by this instance.
267-
var attachableValue: AttachableValue { get }
266+
/// The underlying value represented by this instance.
267+
var wrappedValue: Wrapped { get }
268268
}
269269

270270
extension Attachment where AttachableValue: AttachableWrapper & ~Copyable {
@@ -278,7 +278,7 @@ extension Attachment where AttachableValue: AttachableWrapper & ~Copyable {
278278
/// ```swift
279279
/// let attachableValue = attachment.attachableValue as T
280280
/// ```
281-
public var attachableValue: AttachableValue.AttachableValue { get }
281+
public var attachableValue: AttachableValue.Wrapped { get }
282282
}
283283
```
284284

0 commit comments

Comments
 (0)