Skip to content

Commit 87d86ad

Browse files
ktosoTTOzzi
andauthored
Apply suggestions from code review
Co-authored-by: TTOzzi <[email protected]>
1 parent b85a6b3 commit 87d86ad

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

proposals/NNNN-SerialExecutor-isIsolated.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ This approach is better than not being able to participate in the checks at all
5757
- the crash **messages** offered by these `checkIsolated()` crashes **are often sub-optimal** and confusing
5858
- messages often don't include crucial information about which actor/executor the calling context was _actually_ executing on. Offering only "expected [...]" messages, leading to hard to debug crashes.
5959
- it is **impossible** for the Swift runtime to offer **isolation violation warnings**
60-
- because the Swift runtime _must_ call into a custom executor to verify its isolation, the "pass or crash" method will crash, rather than inform the runtime that a violation ocured and we should warn about it.
60+
- because the Swift runtime _must_ call into a custom executor to verify its isolation, the "pass or crash" method will crash, rather than inform the runtime that a violation occurred and we should warn about it.
6161

6262
Today, it is not possible for the Swift runtime to issue _warnings_ if something is detected to be on not the expected executor, but somehow we'd still like to continue without crashing the application.
6363

@@ -90,9 +90,9 @@ extension SerialExecutor {
9090
}
9191
```
9292

93-
The Swift runtime is free to call the `isIsolated` function whenever it wants to verify if the current context is apropriately isolated by some serial executor.
93+
The Swift runtime is free to call the `isIsolated` function whenever it wants to verify if the current context is appropriately isolated by some serial executor.
9494

95-
In most cases implementing this new API is preferable to implementing `checkIsolated()`, as the Swift runtime is able to offer more detailed error messages when when an isolation failure detected by a call to `isIsolatingCurrentContext()` is detected.
95+
In most cases implementing this new API is preferable to implementing `checkIsolated()`, as the Swift runtime is able to offer more detailed error messages when an isolation failure detected by a call to `isIsolatingCurrentContext()` is detected.
9696

9797
## Detailed design
9898

0 commit comments

Comments
 (0)