-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Update the Swift evolution process documentation to incorporate Swift Testing #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Swift evolution process documentation to incorporate Swift Testing #2729
Conversation
|
@stmontgomery If you are making changes to the contents of the Unexpected changes to the In general, I know there is a plan to bring more projects into the evolution process. It would be great to have some warning ahead of time of what changes are coming and when, so that I can make sure ahead of time that the evolution dashboard doesn't break. (And I realize this comment is not directly related to this PR, but there's no way to comment on the commit that caused the break itself.) |
I'm sorry about that, I was the one who approved and merged the addition of the
I fixed the Swift Evolution Dashboard on Friday in swiftlang/swift-evolution-metadata-extractor#48, and the dashboard appears to be working now. It skips all proposals in the |
rjmccall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mostly just taking the prompt here to document some other long-established changes.
Absolutely, understood, @dempseyatgithub. As @hborla mentioned, we collaborated on #2721 (which is what added content under Now, while we're on the topic: I am hoping we can teach swift-evolution-metadata-extractor how to begin displaying those Swift Testing proposals on the Evolution dashboard as soon as possible. Since I've been coordinating many of the launch details for the new workgroup I was planning to volunteer to contribute changes to accomplish that, but I'm also happy if you'd like to do it @dempseyatgithub. Either way, I just filed swiftlang/swift-evolution-metadata-extractor#49 to track it. |
Co-authored-by: John McCall <[email protected]>
Co-authored-by: John McCall <[email protected]>
This is a small PR to replace two links in `process.md` which still reference the Apple GitHub organization instead of swiftlang. (I noticed these while working on swiftlang#2729 but they were out of scope for that PR.) The existing links aren't broken, they do redirect successfully, but it's nicer to use the correct URLs.
How difficult would it be to set up a GitHub action for PRs that checks to make sure the metadata extractor works as expected? If changes to the repo risk breaking the extractor, having a pre-merge check seems like a good way to mitigate that risk. |
|
@shahmishal can we enable GHA here on this repo? |
|
Yes, we should be able to. I will work with @dempseyatgithub to configure the right testing for the swift-evolution repository. |
rjmccall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This includes a handful of updates and edits to
process.mdwhich documents the Swift evolution process so that it mentions Swift Testing, the Testing Workgroup, and the newly-added Swift Testing template file.