Enable cross-PR testing

Author: ahoppen

.github/workflows/pull_request.yml

@@ -8,9 +8,13 @@ jobs:
   tests:
     name: Test
     uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
-  soundness:
-    name: Soundness
-    uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
     with:
-      license_header_check_enabled: false
-      license_header_check_project_name: "Swift.org"
+      enable_windows_checks: false
+      linux_pre_build_command: |
+        python3 cross-pr-checkout.py
+  # soundness:
+  #   name: Soundness
+  #   uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
+  #   with:
+  #     license_header_check_enabled: false
+  #     license_header_check_project_name: "Swift.org"

Sources/SwiftFormat/Rules/UseShorthandTypeNames.swift

@@ -48,7 +48,7 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
     switch node.name.text {
     case "Array":
       guard let argument = genericArgumentList.firstAndOnly,
-            case .type(let typeArgument) = argument else {
+            case .type(let typeArgument) = argument.argument else {
         newNode = nil
         break
       }
@@ -62,7 +62,7 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
     case "Dictionary":
       guard let arguments = exactlyTwoChildren(of: genericArgumentList),
             case .type(let type0Argument) = arguments.0.argument,
-            caes .type(let type1Argument) = arguments.1.argument else {
+            case .type(let type1Argument) = arguments.1.argument else {
         newNode = nil
         break
       }
@@ -79,7 +79,7 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
         break
       }
       guard let argument = genericArgumentList.firstAndOnly,
-            case .type(let typeArgument) = argument else {
+            case .type(let typeArgument) = argument.argument else {
         newNode = nil
         break
       }
@@ -143,7 +143,7 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
     switch expression.baseName.text {
     case "Array":
       guard let argument = genericArgumentList.firstAndOnly,
-            case .type(let typeArgument) = argument else {
+            case .type(let typeArgument) = argument.argument else {
         newNode = nil
         break
       }
@@ -172,7 +172,7 @@ public final class UseShorthandTypeNames: SyntaxFormatRule {
 
     case "Optional":
       guard let argument = genericArgumentList.firstAndOnly,
-            case .type(let typeArgument) = argument else {
+            case .type(let typeArgument) = argument.argument else {
         newNode = nil
         break
       }

cross-pr-checkout.py

@@ -0,0 +1,22 @@
+import subprocess
+import pathlib
+
+def cross_repo_prs() -> dict[str, str]:
+  return {
+    "swiftlang/swift-syntax": "2859"
+  }
+
+def run(cmd: list[str], cwd: str|None = None):
+  print(" ".join(cmd))
+  subprocess.check_call(cmd, cwd=cwd)
+
+def main():
+  # for repo
+  run(["git", "clone", "https://github.com/swiftlang/swift-syntax.git", "swift-syntax"], cwd="..")
+  run(["git", "fetch", "origin", "pull/2859/merge:pr_merge"], cwd="../swift-syntax")
+  run(["git", "checkout", "main"], cwd="../swift-syntax")
+  run(["git", "reset", "--hard", "pr_merge"], cwd="../swift-syntax")
+  run(["swift", "package", "config", "set-mirror", "--package-url", "https://github.com/swiftlang/swift-syntax.git", "--mirror-url", str(pathlib.Path("../swift-syntax").resolve())])
+
+if __name__ == "__main__":
+  main()