[Core] Add a new finding severity - convention

xedin · xedin · commit 21c122fd9ac4 · 2023-08-01T11:08:03.000-07:00
Identifies programming conventions such as for naming types and functions.
diff --git a/Sources/SwiftFormatCore/Finding.swift b/Sources/SwiftFormatCore/Finding.swift
@@ -17,6 +17,7 @@ public struct Finding {
     case warning
     case error
     case refactoring
+    case convention
   }
 
   /// The file path and location in that file where a finding was encountered.
diff --git a/Sources/swift-format/Utilities/DiagnosticsEngine.swift b/Sources/swift-format/Utilities/DiagnosticsEngine.swift
@@ -117,6 +117,7 @@ final class DiagnosticsEngine {
     case .error: severity = .error
     case .warning: severity = .warning
     case .refactoring: severity = .warning
+    case .convention: severity = .warning
     }
     return Diagnostic(
       severity: severity,

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ public struct Finding {`
`17`	`17`	`case warning`
`18`	`18`	`case error`
`19`	`19`	`case refactoring`
	`20`	`+ case convention`
`20`	`21`	`}`
`21`	`22`
`22`	`23`	`/// The file path and location in that file where a finding was encountered.`
Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,7 @@ final class DiagnosticsEngine {`
`117`	`117`	`case .error: severity = .error`
`118`	`118`	`case .warning: severity = .warning`
`119`	`119`	`case .refactoring: severity = .warning`
	`120`	`+ case .convention: severity = .warning`
`120`	`121`	`}`
`121`	`122`	`return Diagnostic(`
`122`	`123`	`severity: severity,`